You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/23 12:16:41 UTC
[GitHub] [maven-wrapper] jimisola opened a new pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
jimisola opened a new pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14
Replaced jarUrl with wrapperUrl in mvnw
My first maven contribution in 15 years or so. Please advise if I missed out on something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] hboutemy merged pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
hboutemy merged pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] hboutemy commented on pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14#issuecomment-1020618355
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] jimisola commented on pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
jimisola commented on pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14#issuecomment-1019581805
I agree. I've renamed DOWNLOAD_URL to WRAPPER_URL in mvnw.cmd. Although, it was a simple find-replace it has not been tested since I don't use Windows.
Not sure what choices you are referring to (command line option?), but that will be clearer with another Jira issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] hboutemy edited a comment on pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14#issuecomment-1019575159
nice
while at it, we could rename also DOWNLOAD_URL to WRAPPER_URL in mvnw.cmd, WDYT?
and eventually better align choices in mvnw.cmd vs mvnw: but this one should be another Jira issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] hboutemy commented on pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14#issuecomment-1020612858
> Not sure what choices you are referring to (command line option?), but that will be clearer with another Jira issue :)
I have no concrete case in mind, just the idea that there may be other cases of such differences between mvnw.cmd and mvnw that could be avoided to have a better consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] hboutemy merged pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
hboutemy merged pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] hboutemy commented on pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14#issuecomment-1019575159
nice
while at it, we could rename also DOWNLOAD_URL to WRAPPER_URL in mvnw.cmd, WDYT?
and eventually better align choices in mvnw.cmd vs mvnw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] hboutemy commented on pull request #14: [MWRAPPER-47] - Use name wrapperUrl consistently in Maven Wrapper files/scripts
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #14:
URL: https://github.com/apache/maven-wrapper/pull/14#issuecomment-1020612858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org