[GitHub] [airflow] kaxil commented on a change in pull request #8150: [AIRFLOW-3126] Add option to specify additional K8s volumes

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #8150:
URL: https://github.com/apache/airflow/pull/8150#discussion_r442544061



##########
File path: airflow/config_templates/config.yml
##########
@@ -1898,6 +1898,22 @@
       type: string
       example: ~
       default: ""
+    - name: extra_volume_mounts
+      description: |
+        Extra volumes to be mounted in worker pods.  Volumes are specified as
+        keys in a JSON object with nested JSON values specifying each volume's
+        options.  Recognized options are `claim_name` or `secret_name`
+        (required), `mount_path` (required), `read_only` (boolean, default
+        null), `sub_path` (default null), `secret_key` (string, default null),
+        `secret_mode` (string, default null).
+      version_added: ~
+      type: string
+      example: >-
+        "{{\"secret_vol\": {{\"secret_name\": \"some-secret\",
+        \"mount_path\": \"/dir1\", \"sub_path\": \"subpath1\",
+        \"secret_mode\": \"440\"}},
+        \"pvc\": {{\"claim_name\": \"some-pvc\", \"mount_path\": \"/dir2\"}}}}"

Review comment:
       ```suggestion
           {{"secret_vol": {{"secret_name": "some-secret", "mount_path": "/dir1", "sub_path": "subpath1",
           "secret_mode": "440"}}, "pvc": {{"claim_name": "some-pvc", "mount_path": "/dir2"}}}}
   ```
   
   should work




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org