[GitHub] [spark] WweiL commented on a diff in pull request #40906: [SPARK-43134] [CONNECT] [SS] JVM client StreamingQuery exception() API

["WweiL (via GitHub)" <gi...@apache.org>]

WweiL commented on code in PR #40906:
URL: https://github.com/apache/spark/pull/40906#discussion_r1175911789


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala:
##########
@@ -199,6 +205,26 @@ class RemoteStreamingQuery(
     // scalastyle:on println
   }
 
+  override def exception: Option[StreamingQueryException] = {
+    val exception = executeQueryCmd(_.setException(true)).getException
+    if (exception.hasExceptionMessage) {
+      // TODO(SPARK-43206): Add more information to StreamingQueryException.
+      Some(
+        new StreamingQueryException(
+          "",
+          cause = null,
+          "",
+          "",
+          errorClass = "STREAM_FAILED",

Review Comment:
   I believe it's not yet... The general error handling framework for jvm client is not ready yet. And they only include error message and stack trace so far. I'm thinking to implement our own proto message to also include the offsets, which will be added in next PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org