You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (Created) (JIRA)" <ji...@apache.org> on 2012/04/02 23:01:24 UTC
[jira] [Created] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Security support broken in CLI (manual) failover controller
-----------------------------------------------------------
Key: HADOOP-8243
URL: https://issues.apache.org/jira/browse/HADOOP-8243
Project: Hadoop Common
Issue Type: Bug
Components: ha, security
Affects Versions: 2.0.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Critical
Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245742#comment-13245742 ]
Hudson commented on HADOOP-8243:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1997 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1997/])
HADOOP-8243. Security support broken in CLI (manual) failover controller. Contributed by Todd Lipcon. (Revision 1309135)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309135
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceTarget.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ZKFailoverController.java
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8243:
--------------------------------
Status: Patch Available (was: Open)
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245724#comment-13245724 ]
Hudson commented on HADOOP-8243:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2059 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2059/])
HADOOP-8243. Security support broken in CLI (manual) failover controller. Contributed by Todd Lipcon. (Revision 1309135)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309135
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceTarget.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ZKFailoverController.java
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245661#comment-13245661 ]
Aaron T. Myers commented on HADOOP-8243:
----------------------------------------
+1, the patch looks good to me. Thanks a lot, Todd.
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245728#comment-13245728 ]
Hudson commented on HADOOP-8243:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1984 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1984/])
HADOOP-8243. Security support broken in CLI (manual) failover controller. Contributed by Todd Lipcon. (Revision 1309135)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309135
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceTarget.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ZKFailoverController.java
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246229#comment-13246229 ]
Hudson commented on HADOOP-8243:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1005 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1005/])
HADOOP-8243. Security support broken in CLI (manual) failover controller. Contributed by Todd Lipcon. (Revision 1309135)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309135
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceTarget.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ZKFailoverController.java
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244675#comment-13244675 ]
Hadoop QA commented on HADOOP-8243:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521040/hadoop-8243.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/814//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/814//console
This message is automatically generated.
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246273#comment-13246273 ]
Hudson commented on HADOOP-8243:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1040 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1040/])
HADOOP-8243. Security support broken in CLI (manual) failover controller. Contributed by Todd Lipcon. (Revision 1309135)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309135
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/FailoverController.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceTarget.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ZKFailoverController.java
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8243:
--------------------------------
Attachment: hadoop-8243.txt
This patch fixes the issue. I tested manually by setting up a secure HA cluster and running haadmin with {{-failover}}, {{-checkHealth}}, {{-transitionToActive}}, {{-transitionToStandby}}, and {{-getServiceState}} subcommands.
These manual tests are covered by the HA test plan.
Unfortunately there are no automated tests for security here. I tried to get the new ApacheDS-based security test infrastructure to work, but it doesn't work correctly in my environment. Please see my comment here: https://issues.apache.org/jira/browse/HDFS-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242722#comment-13242722
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8243:
--------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to branch-2 and trunk, thx for the review
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8243) Security support broken in CLI
(manual) failover controller
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244625#comment-13244625 ]
Todd Lipcon commented on HADOOP-8243:
-------------------------------------
I should note I also ran TestDFSHAAdmin and TestDFSHAAdminMiniCluster against this common patch, and they both passed.
> Security support broken in CLI (manual) failover controller
> -----------------------------------------------------------
>
> Key: HADOOP-8243
> URL: https://issues.apache.org/jira/browse/HADOOP-8243
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha, security
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hadoop-8243.txt
>
>
> Some recent refactoring accidentally caused the proxies in some places to get created with a default Configuration, instead of using the Configuration set up by the DFSHAAdmin tool. This causes the HAServiceProtocol to be missing the configuration which specifies the NN principle -- and thus breaks the CLI HAAdmin tool in secure setups.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira