You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Indhumathi27 <gi...@git.apache.org> on 2018/07/27 06:56:48 UTC

[GitHub] carbondata pull request #2569: [CARBONDATA-2791]Fix Adaptive Encoding for Do...

GitHub user Indhumathi27 opened a pull request:

    https://github.com/apache/carbondata/pull/2569

    [CARBONDATA-2791]Fix Adaptive Encoding for Double if exceeds LONG.Max_value

    **What this PR for?**
    
    If Factor(decimalcount) * absMaxValue exceeds LONG.MAX_VALUE, then go for direct compression.
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [x] Testing done
           Testcases added
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Indhumathi27/carbondata adapfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2569
    
----
commit c26897b2d8d37ba4e5361da7585dfe6942c42f5a
Author: Indhumathi27 <in...@...>
Date:   2018-07-27T06:52:25Z

    [CARBONDATA-2791]Fix Adaptive Encoding for Double if exceeds LONG.Max_value

----


---

[GitHub] carbondata pull request #2569: [CARBONDATA-2791]Fix Encoding for Double if e...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2569


---

[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2569
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7563/



---

[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...

Posted by Indhumathi27 <gi...@git.apache.org>.
Github user Indhumathi27 commented on the issue:

    https://github.com/apache/carbondata/pull/2569
  
    Retest this please


---

[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2569
  
    LGTM


---

[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2569
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6027/



---

[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2569
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6306/



---

[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2569
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7553/



---

[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2569
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6318/



---