You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/21 03:53:04 UTC
[GitHub] [iotdb] xingtanzjr opened a new pull request, #6358: Optimize write and MPP framework
xingtanzjr opened a new pull request, #6358:
URL: https://github.com/apache/iotdb/pull/6358
## Description
1. Remove some duplicated log
2. Fix the issue that `getStatus()` will be queued for a long while (50-70ms)
3. Fix the issue that the thread is occupied when sleeping in QueryTerminator, which lead to the task in same thread-pool will be queued for a long while to waiting the thread being released.
4. The write operation is changed to Sync using client thread. (The testing is in progress and the async write won't be discard)
After this change, the write throughput in 1C1D is similar with new-standalone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #6358: Optimize write and MPP framework
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #6358:
URL: https://github.com/apache/iotdb/pull/6358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6358: Optimize write and MPP framework
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6358:
URL: https://github.com/apache/iotdb/pull/6358#issuecomment-1161279745
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=6358)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_coverage&view=list) [34.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #6358: Optimize write and MPP framework
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6358:
URL: https://github.com/apache/iotdb/pull/6358#issuecomment-1161446576
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=6358)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=6358&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_coverage&view=list) [34.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=6358&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #6358: Optimize write and MPP framework
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #6358:
URL: https://github.com/apache/iotdb/pull/6358#issuecomment-1161278261
[](https://coveralls.io/builds/50198340)
Coverage decreased (-0.03%) to 43.824% when pulling **b29b8bb16539f2cfea925a9873720540953be463 on xingtanzjr/write_opt_version1** into **c8145715d9291bbb1f270a7b7f897d93da30bf59 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #6358: Optimize write and MPP framework
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #6358:
URL: https://github.com/apache/iotdb/pull/6358#discussion_r902138764
##########
server/src/assembly/resources/conf/iotdb-engine.properties:
##########
@@ -1020,6 +1020,14 @@ timestamp_precision=ms
# Datatype: int
# datanode_schema_cache_size=10000
+# thread pool size for read operation in DataNode's coordinator.
+# Datatype: int
+# coordinator_read_executor_size=30
+
+# thread pool size for write operation in DataNode's coordinator.
+# Datatype: int
+# coordinator_read_executor_size=30
Review Comment:
```suggestion
# coordinator_write_executor_size=30
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #6358: Optimize write and MPP framework
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #6358:
URL: https://github.com/apache/iotdb/pull/6358#discussion_r902140145
##########
server/src/assembly/resources/conf/iotdb-engine.properties:
##########
@@ -1020,6 +1020,14 @@ timestamp_precision=ms
# Datatype: int
# datanode_schema_cache_size=10000
Review Comment:
```suggestion
# datanode_schema_cache_size=1000000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #6358: Optimize write and MPP framework
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on code in PR #6358:
URL: https://github.com/apache/iotdb/pull/6358#discussion_r902239882
##########
server/src/assembly/resources/conf/iotdb-engine.properties:
##########
@@ -1020,6 +1020,14 @@ timestamp_precision=ms
# Datatype: int
# datanode_schema_cache_size=10000
+# thread pool size for read operation in DataNode's coordinator.
+# Datatype: int
+# coordinator_read_executor_size=30
+
+# thread pool size for write operation in DataNode's coordinator.
+# Datatype: int
+# coordinator_read_executor_size=30
Review Comment:
Fixed
##########
server/src/assembly/resources/conf/iotdb-engine.properties:
##########
@@ -1020,6 +1020,14 @@ timestamp_precision=ms
# Datatype: int
# datanode_schema_cache_size=10000
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org