You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "LostArtist (via GitHub)" <gi...@apache.org> on 2023/07/11 14:23:22 UTC

[GitHub] [camel] LostArtist opened a new pull request, #10664: CAMEL-19600: camel-atom test code cleanups

LostArtist opened a new pull request, #10664:
URL: https://github.com/apache/camel/pull/10664

   - Deleted redundant variables and declarations
   - Simplified assertions
   - Fixed grammar issues
   
   
   # Description
   
   <!--
   - Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   -->
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   -->
   
   - [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
   
   <!--
   You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske merged pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #10664:
URL: https://github.com/apache/camel/pull/10664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10664:
URL: https://github.com/apache/camel/pull/10664#issuecomment-1636831434

   @LostArtist are you able to correct the findings from the review, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10664:
URL: https://github.com/apache/camel/pull/10664#issuecomment-1630929275

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
   
   :warning: Please note that the changes on this PR may be **tested automatically** if they change components.
   
   :robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] LostArtist commented on pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "LostArtist (via GitHub)" <gi...@apache.org>.
LostArtist commented on PR #10664:
URL: https://github.com/apache/camel/pull/10664#issuecomment-1637083882

   Thank you all for your comments. Sorry, there was no way to fix errors earlier. Hope I did it right this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on a diff in pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #10664:
URL: https://github.com/apache/camel/pull/10664#discussion_r1259837881


##########
components/camel-optaplanner/pom.xml:
##########
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
+git <?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   To revert too as it seems to be a typo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on a diff in pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #10664:
URL: https://github.com/apache/camel/pull/10664#discussion_r1259837219


##########
components/camel-atom/src/test/java/org/apache/camel/component/atom/UpdatedDateFilterTest.java:
##########
@@ -28,8 +28,7 @@
 import org.junit.jupiter.api.condition.DisabledOnOs;
 import org.junit.jupiter.api.condition.OS;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.*;

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on a diff in pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #10664:
URL: https://github.com/apache/camel/pull/10664#discussion_r1259836671


##########
components/camel-atom/src/test/java/org/apache/camel/component/atom/AtomHttpNoCamelParametersTest.java:
##########
@@ -21,8 +21,7 @@
 import org.junit.jupiter.api.condition.DisabledOnOs;
 import org.junit.jupiter.api.condition.OS;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.*;

Review Comment:
   Please revert this change, we don't use this kind of import



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #10664: CAMEL-19600: camel-atom test code cleanups

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10664:
URL: https://github.com/apache/camel/pull/10664#issuecomment-1637596977

   All comments have been fixed. It's good to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org