You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 09:42:51 UTC
[GitHub] [arrow-rs] Ted-Jiang opened a new pull request, #2076: Support skip_values in ByteArrayColumnValueDecoder
Ted-Jiang opened a new pull request, #2076:
URL: https://github.com/apache/arrow-rs/pull/2076
# Which issue does this PR close?
Closes #2072.
Support skip values during decoding, will support bytesArray first which include:
```
Plain(ByteArrayDecoderPlain),
Dictionary(ByteArrayDecoderDictionary),
DeltaLength(ByteArrayDecoderDeltaLength),
DeltaByteArray(ByteArrayDecoderDelta),
```
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#issuecomment-1185592425
@tustvold PTALπ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922092728
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +787,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
Review Comment:
It's better to add more test cases:
1. all values are null for corner case
2. skip value with null data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#issuecomment-1186152876
Benchmark runs are scheduled for baseline = 32867e332ba901542a6adc5c81b61bc66002c751 and contender = 72dada6d656e88f0d07efa2cc32ea9670d061fc2. 72dada6d656e88f0d07efa2cc32ea9670d061fc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6bae1359f53d4475bff69bd691ffdd5b...2727874daea445068ec29ca65620e641/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/85e80489e9354efea11fc5b4fa093ed3...fb6d5548a0694b5cb6c62947edd428c4/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/649abcd058954efab36bc5a105714ea0...0c6195c7776a4ab8a142125cb6f3eb0d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/026346993fe3422e889299f7212a0e00...423766dcd96b490eae3b46de31ccb567/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922665853
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +776,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
+ byte_array_all_encodings(vec!["hello", "world", "a", "b"]);
+
+ let column_desc = utf8_column();
+ let mut decoder = ByteArrayColumnValueDecoder::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ for (encoding, page) in pages {
+ let mut output = OffsetBuffer::<i32>::default();
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
+
+ assert_eq!(output.values.as_slice(), "hello".as_bytes());
+ assert_eq!(output.offsets.as_slice(), &[0, 5]);
+
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
Review Comment:
Because for backwards compatibility we need to support decoding to a slice, as opposed to a container that tracks its length
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922305417
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -589,6 +680,38 @@ impl ByteArrayDecoderDictionary {
}
Ok(values_read)
}
+
+ fn skip<I: OffsetSizeTrait + ScalarValue>(
+ &mut self,
+ dict: &OffsetBuffer<I>,
+ to_skip: usize,
+ ) -> Result<usize> {
+ let to_skip = to_skip.min(self.max_remaining_values);
+ // All data must be NULL
+ if dict.is_empty() {
+ return Ok(0);
+ }
+
+ let mut values_skip = 0;
+ while values_skip < to_skip {
+ if self.index_offset == self.index_buf_len {
+ let read = self.decoder.get_batch(self.index_buf.as_mut())?;
Review Comment:
Possibly something for a follow up PR, but it would be nice if we could avoid decoding values only to dump them on the floor
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +776,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
+ byte_array_all_encodings(vec!["hello", "world", "a", "b"]);
+
+ let column_desc = utf8_column();
+ let mut decoder = ByteArrayColumnValueDecoder::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ for (encoding, page) in pages {
+ let mut output = OffsetBuffer::<i32>::default();
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
+
+ assert_eq!(output.values.as_slice(), "hello".as_bytes());
+ assert_eq!(output.offsets.as_slice(), &[0, 5]);
+
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
Review Comment:
```suggestion
assert_eq!(decoder.read(&mut output, 1..2).unwrap(), 1);
```
The decoder doesn't actually care, as it keeps track of the number of read values, but this is technically more correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922647447
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +776,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
+ byte_array_all_encodings(vec!["hello", "world", "a", "b"]);
+
+ let column_desc = utf8_column();
+ let mut decoder = ByteArrayColumnValueDecoder::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ for (encoding, page) in pages {
+ let mut output = OffsetBuffer::<i32>::default();
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
+
+ assert_eq!(output.values.as_slice(), "hello".as_bytes());
+ assert_eq!(output.offsets.as_slice(), &[0, 5]);
+
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
Review Comment:
Your are right! π, finally it just need the `length`.
Why not change
```
fn read(&mut self, out: &mut Self::Slice, range: Range<usize>) -> Result<usize>;
```
to
```
fn read(&mut self, out: &mut Self::Slice, length: usize) -> Result<usize>;
```
Is there any reason π€
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +776,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
+ byte_array_all_encodings(vec!["hello", "world", "a", "b"]);
+
+ let column_desc = utf8_column();
+ let mut decoder = ByteArrayColumnValueDecoder::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ for (encoding, page) in pages {
+ let mut output = OffsetBuffer::<i32>::default();
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
+
+ assert_eq!(output.values.as_slice(), "hello".as_bytes());
+ assert_eq!(output.offsets.as_slice(), &[0, 5]);
+
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
Review Comment:
Is this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922647447
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +776,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
+ byte_array_all_encodings(vec!["hello", "world", "a", "b"]);
+
+ let column_desc = utf8_column();
+ let mut decoder = ByteArrayColumnValueDecoder::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ for (encoding, page) in pages {
+ let mut output = OffsetBuffer::<i32>::default();
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
+
+ assert_eq!(output.values.as_slice(), "hello".as_bytes());
+ assert_eq!(output.offsets.as_slice(), &[0, 5]);
+
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
Review Comment:
yes, finally it just need the `length`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922647447
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +776,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
+ byte_array_all_encodings(vec!["hello", "world", "a", "b"]);
+
+ let column_desc = utf8_column();
+ let mut decoder = ByteArrayColumnValueDecoder::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ for (encoding, page) in pages {
+ let mut output = OffsetBuffer::<i32>::default();
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
+
+ assert_eq!(output.values.as_slice(), "hello".as_bytes());
+ assert_eq!(output.offsets.as_slice(), &[0, 5]);
+
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
Review Comment:
Your are right! π, finally it just need the `length`.
Why not change
```
fn read(&mut self, out: &mut Self::Slice, range: Range<usize>) -> Result<usize>;
```
to
```
fn read(&mut self, out: &mut Self::Slice, length: usize) -> Result<usize>;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922647109
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -589,6 +680,38 @@ impl ByteArrayDecoderDictionary {
}
Ok(values_read)
}
+
+ fn skip<I: OffsetSizeTrait + ScalarValue>(
+ &mut self,
+ dict: &OffsetBuffer<I>,
+ to_skip: usize,
+ ) -> Result<usize> {
+ let to_skip = to_skip.min(self.max_remaining_values);
+ // All data must be NULL
+ if dict.is_empty() {
+ return Ok(0);
+ }
+
+ let mut values_skip = 0;
+ while values_skip < to_skip {
+ if self.index_offset == self.index_buf_len {
+ let read = self.decoder.get_batch(self.index_buf.as_mut())?;
Review Comment:
Agree! file an issue #2088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#discussion_r922665853
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -653,6 +776,57 @@ mod tests {
}
}
+ #[test]
+ fn test_byte_array_decoder_skip() {
+ let (pages, encoded_dictionary) =
+ byte_array_all_encodings(vec!["hello", "world", "a", "b"]);
+
+ let column_desc = utf8_column();
+ let mut decoder = ByteArrayColumnValueDecoder::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ for (encoding, page) in pages {
+ let mut output = OffsetBuffer::<i32>::default();
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
+
+ assert_eq!(output.values.as_slice(), "hello".as_bytes());
+ assert_eq!(output.offsets.as_slice(), &[0, 5]);
+
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+ assert_eq!(decoder.skip_values(1).unwrap(), 1);
+
+ assert_eq!(decoder.read(&mut output, 0..1).unwrap(), 1);
Review Comment:
Because for backwards compatibility we need to support decoding to a slice, as opposed to a container that tracks its length.
See ColumnValueDecoderImpl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2076: Support skip_values in ByteArrayColumnValueDecoder
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2076:
URL: https://github.com/apache/arrow-rs/pull/2076#issuecomment-1185586598
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2076?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2076](https://codecov.io/gh/apache/arrow-rs/pull/2076?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (96823a1) into [master](https://codecov.io/gh/apache/arrow-rs/commit/86543a4b835f898308bd28a33d0da9d2ea7a9b35?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86543a4) will **increase** coverage by `0.01%`.
> The diff coverage is `89.62%`.
```diff
@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
+ Coverage 83.61% 83.62% +0.01%
==========================================
Files 223 223
Lines 58539 58642 +103
==========================================
+ Hits 48947 49040 +93
- Misses 9592 9602 +10
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2076?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [parquet/src/arrow/array\_reader/byte\_array.rs](https://codecov.io/gh/apache/arrow-rs/pull/2076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyL2J5dGVfYXJyYXkucnM=) | `86.31% <89.62%> (+1.83%)` | :arrow_up: |
| [...row/src/array/builder/string\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvc3RyaW5nX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `90.64% <0.00%> (-0.72%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.23%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2076/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `64.41% <0.00%> (+0.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2076?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2076?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86543a4...96823a1](https://codecov.io/gh/apache/arrow-rs/pull/2076?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org