You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2019/06/07 05:06:14 UTC

[incubator-superset] branch revert-7218-VIZ-414 created (now c1bbe29)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a change to branch revert-7218-VIZ-414
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at c1bbe29  Revert "Allow bigint to be used as time column in Presto (#7218)"

This branch includes the following new commits:

     new c1bbe29  Revert "Allow bigint to be used as time column in Presto (#7218)"

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-superset] 01/01: Revert "Allow bigint to be used as time column in Presto (#7218)"

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch revert-7218-VIZ-414
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit c1bbe295aeb384ae7b63ab69e4df1d510dcf1a24
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Thu Jun 6 22:05:55 2019 -0700

    Revert "Allow bigint to be used as time column in Presto (#7218)"
    
    This reverts commit 6998b1014a2341af51d8720a4a371fc6a2042a6e.
---
 superset/db_engine_specs.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index 620ac4e..a5928e8 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -832,8 +832,6 @@ class PrestoEngineSpec(BaseEngineSpec):
             return "from_iso8601_date('{}')".format(dttm.isoformat()[:10])
         if tt == 'TIMESTAMP':
             return "from_iso8601_timestamp('{}')".format(dttm.isoformat())
-        if tt == 'BIGINT':
-            return "to_unixtime(from_iso8601_timestamp('{}'))".format(dttm.isoformat())
         return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S'))
 
     @classmethod