[jira] [Commented] (LUCENE-10008) CommonGramsFilterFactory doesn't respect ignoreCase=true when default stopwords are used

["Vigya Sharma (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365013#comment-17365013 ] 

Vigya Sharma commented on LUCENE-10008:
---------------------------------------

Lucene newbie here. This looks like a simple change. I'd like to pick this up if no one is working on it already (and if it makes sense to have {{CommonGramsFilterFactory}} honor the {{ignoreCase}} flag).

> CommonGramsFilterFactory doesn't respect ignoreCase=true when default stopwords are used
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10008
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10008
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Chris M. Hostetter
>            Priority: Major
>
> CommonGramsFilterFactory's use of the "words" and "ignoreCase" config options is inconsistent with how StopFilterFactory uses them - leading to "ignoreCase=true" not being respected unless "words" is specified...
> StopFilterFactory...
> {code:java}
>   public void inform(ResourceLoader loader) throws IOException {
>     if (stopWordFiles != null) {
>       ...
>     } else {
>       ...
>       stopWords = new CharArraySet(EnglishAnalyzer.ENGLISH_STOP_WORDS_SET, ignoreCase);
>     }
>   }
> {code}
> CommonGramsFilterFactory...
> {code:java}
>   @Override
>   public void inform(ResourceLoader loader) throws IOException {
>     if (commonWordFiles != null) {
>       ...
>     } else {
>       commonWords = EnglishAnalyzer.ENGLISH_STOP_WORDS_SET;
>     }
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org