You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/19 15:24:27 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #5641: GEODE-8630: Add Redis UNLINK command as synonym to DEL
jdeppe-pivotal opened a new pull request #5641:
URL: https://github.com/apache/geode/pull/5641
- This does not implement async deletes
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5641: GEODE-8630: Add Redis UNLINK command as synonym to DEL
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5641:
URL: https://github.com/apache/geode/pull/5641#discussion_r509614586
##########
File path: geode-redis/README.md
##########
@@ -207,7 +207,7 @@ start server \
| | SUNION | CLUSTER RESET |
| | SUNIONSTORE | CLUSTER SAVECONFIG |
| | TIME | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
+| | UNLINK [1] | CLUSTER SETSLOT |
Review comment:
Good idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5641: GEODE-8630: Add Redis UNLINK command as synonym to DEL
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5641:
URL: https://github.com/apache/geode/pull/5641#discussion_r509369824
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -142,6 +142,7 @@
RENAME(new RenameExecutor(), SUPPORTED, new ExactParameterRequirements(3)),
TTL(new TTLExecutor(), SUPPORTED, new ExactParameterRequirements(2)),
TYPE(new TypeExecutor(), SUPPORTED, new ExactParameterRequirements(2)),
+ UNLINK(new DelExecutor(), SUPPORTED, new MinimumParameterRequirements(2)),
Review comment:
Oops - good catch. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #5641: GEODE-8630: Add Redis UNLINK command as synonym to DEL
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #5641:
URL: https://github.com/apache/geode/pull/5641#discussion_r509366816
##########
File path: geode-redis/README.md
##########
@@ -207,7 +207,7 @@ start server \
| | SUNION | CLUSTER RESET |
| | SUNIONSTORE | CLUSTER SAVECONFIG |
| | TIME | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
+| | UNLINK [1] | CLUSTER SETSLOT |
Review comment:
We should update this docs file as well `redis_api_for_geode.html.md.erb`. It may also be good to ask John Martin to review these doc updates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #5641: GEODE-8630: Add Redis UNLINK command as synonym to DEL
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #5641:
URL: https://github.com/apache/geode/pull/5641#discussion_r509367538
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -142,6 +142,7 @@
RENAME(new RenameExecutor(), SUPPORTED, new ExactParameterRequirements(3)),
TTL(new TTLExecutor(), SUPPORTED, new ExactParameterRequirements(2)),
TYPE(new TypeExecutor(), SUPPORTED, new ExactParameterRequirements(2)),
+ UNLINK(new DelExecutor(), SUPPORTED, new MinimumParameterRequirements(2)),
Review comment:
We said it was `Unsupported` in the README, but added it as `Supported` here. What did we ultimately decide?
##########
File path: geode-redis/README.md
##########
@@ -207,7 +207,7 @@ start server \
| | SUNION | CLUSTER RESET |
| | SUNIONSTORE | CLUSTER SAVECONFIG |
| | TIME | CLUSTER SET-CONFIG-EPOCH |
-| | | CLUSTER SETSLOT |
+| | UNLINK [1] | CLUSTER SETSLOT |
Review comment:
We should update this docs file as well `redis_api_for_geode.html.md`. It may also be good to ask John Martin to review these doc updates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal merged pull request #5641: GEODE-8630: Add Redis UNLINK command as synonym to DEL
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5641:
URL: https://github.com/apache/geode/pull/5641
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org