[jira] Commented: (MODPYTHON-94) Calling APR optional functions provided by mod_ssl

["Graham Dumpleton (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/MODPYTHON-94?page=comments#action_12366727 ] 

Graham Dumpleton commented on MODPYTHON-94:
-------------------------------------------

The attached patch uses Python native bool type.

+    is_https = optfn_is_https && optfn_is_https(self->request_rec->connection);
+
+    result = is_https ? Py_True : Py_False;
+
+    Py_INCREF(result);
+    return result;

If mod_python is to still support Python 2.2, which it looks like we are still because of Nokia work, then can't use the Python bool type yet as that was only added to Python 2.3.

  http://www.python.org/peps/pep-0285.html



> Calling APR optional functions provided by mod_ssl
> --------------------------------------------------
>
>          Key: MODPYTHON-94
>          URL: http://issues.apache.org/jira/browse/MODPYTHON-94
>      Project: mod_python
>         Type: New Feature
>   Components: core
>  Environment: Apache 2
>     Reporter: Deron Meranda
>      Fix For: 3.3
>  Attachments: modpython4.tex.patch, requestobject.c.patch
>
> mod_python is not able to invoke APR Optional Functions.  There are
> some cases however where this could be of great benifit.
> For example, consider writing an authentication or authorization handler
> which needs to determine SSL properties (even if to just answer the
> simple question: is the connection SSL encrypted).  The normal way of
> looking in the subprocess_env for SSL_* variables does not work in those
> early handler phases because those variables are not set until the fixup phase.
> The mod_ssl module though does provide both a ssl_is_https() and
> ssl_var_lookup() optional functions which can be used in earlier
> phases.  For example look at how mod_rewrite calls those; using
> the APR_DECLARE_OPTIONAL_FN and APR_RETRIEVE_OPTIONAL_FN
> macros.
> I can see how it might be very hard to support optional functions in
> general because of the C type linkage issue, but perhaps a select few
> could be coded directly into mod_python.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira