[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4069: [CARBONDATA-3971] Added session property details in Configuration parameters for reindex/repair commands

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #4069:
URL: https://github.com/apache/carbondata/pull/4069#discussion_r550402543



##########
File path: docs/configuration-parameters.md
##########
@@ -96,8 +96,8 @@ This section provides the details of all the configurations required for the Car
 | carbon.binary.decoder | None | Support configurable decode for loading. Two decoders supported: base64 and hex |
 | carbon.local.dictionary.size.threshold.inmb | 4 | size based threshold for local dictionary in MB, maximum allowed size is 16 MB. |
 | carbon.enable.bad.record.handling.for.insert | false | by default, disable the bad record and converter step during "insert into" |
-| carbon.load.si.repair | true | by default, enable loading for failed segments in SI during load/insert command |
-| carbon.si.repair.limit | (none) | Number of failed segments to be loaded in SI when repairing missing segments in SI, by default load all the missing segments. Supports value from 0 to 2147483646 |
+| carbon.load.si.repair | true | by default, enable loading for failed segments in SI during load/insert command. Session level property, can be configured using the set command |

Review comment:
       If carbon common constants, @CarbonProperty(dynamicConfigurable = true).
   
   No need to specifically mention it is supported in set command I guess




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org