You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/02 11:57:22 UTC

[GitHub] [beam] arne-alex commented on a diff in pull request #23333: Track time on Cloud Dataflow streaming data reads and export via heartbeats

arne-alex commented on code in PR #23333:
URL: https://github.com/apache/beam/pull/23333#discussion_r1011639382


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1197,13 +1239,36 @@ public State getState() {
     }
 
     public void setState(State state) {
+      Instant now = clock.get();

Review Comment:
   I've run two different pipelines that include this PR with Google Cloud Profiler enabled. They spent 105µs out of 18.65s overall and 4.45ms out of 16.43s overall modifying/reading Work.State, respectively. This is a negligible fraction of CPU time. If there's any at all, any performance regression would be negligible, too.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org