You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2019/06/11 21:33:33 UTC
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13586
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Some of the e2e tests create tables and databases on S3. HMS operations
like dropDatabaseCascade can take significant time (3-5 min) in such
tests. If the HMS Client times out, it retries for a configurable number
of times. Unfortunately, HMS client is not smart enough to understand
which operations should be retried. Eg, a drop database operation which
is timedout on the client side, should not be retried since the server
thread may have succeeded before the next retry. This would cause the
client to receive a NoSuchObjectException which would look like a flaky
test failure on the Impala side.
This patch increases the metastore client.socket.timeout for
the tests so that such flaky test failures are reduced.
Note:
1. The timeout value of 5 min was chosen based on looking at logs for
one such failure where the HMS API took about 3.5 min. Once this patch
is deployed we should continue to see if such failures reoccur and
readjust the client timeout value accordingly.
Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13586/1
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3567/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:20:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-7154: Increase metastore client time out for tests
> The first line of the commit message should contain a brief description of
Done
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG@23
PS2, Line 23: 10 mi
> Stale comment?
yeah, Thanks for catching this.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:26:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
> The first line of the commit message should contain a brief description of
ping?
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py
File fe/src/test/resources/hive-site.xml.py:
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py@36
PS2, Line 36: retry.delay
> It does not. This is the delay between successive retry attempts. Although
Ah, thanks for the explanation. It seems non-obvious enough to warrant a brief comment in the file itself, but I'll let you decide.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:25:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
IMPALA-7154: Increase metastore client time out for tests
Some of the e2e tests create tables and databases on S3. HMS operations
like dropDatabaseCascade can take significant time (3-5 min) in such
tests. If the HMS Client times out, it retries for a configurable number
of times. Unfortunately, HMS client is not smart enough to understand
which operations should be retried. Eg, a drop database operation which
is timedout on the client side, should not be retried since the server
thread may have succeeded before the next retry. This would cause the
client to receive a NoSuchObjectException which would look like a flaky
test failure on the Impala side.
This patch increases the metastore client.socket.timeout for
the tests so that such flaky test failures are reduced.
Note:
1. The timeout value of 10 min was chosen based on looking at logs for
one such failure where the HMS API took about 3.5 min. Once this patch
is deployed we should continue to see if such failures reoccur and
readjust the client timeout value accordingly.
Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13586/4
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:32:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
IMPALA-7154: Increase metastore client time out for tests
Some of the e2e tests create tables and databases on S3. HMS operations
like dropDatabaseCascade can take significant time (3-5 min) in such
tests. If the HMS Client times out, it retries for a configurable number
of times. Unfortunately, HMS client is not smart enough to understand
which operations should be retried. Eg, a drop database operation which
is timedout on the client side, should not be retried since the server
thread may have succeeded before the next retry. This would cause the
client to receive a NoSuchObjectException which would look like a flaky
test failure on the Impala side.
This patch increases the metastore client.socket.timeout for
the tests so that such flaky test failures are reduced.
Note:
1. The timeout value of 10 min was chosen based on looking at logs for
one such failure where the HMS API took about 3.5 min. Once this patch
is deployed we should continue to see if such failures reoccur and
readjust the client timeout value accordingly.
Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Reviewed-on: http://gerrit.cloudera.org:8080/13586
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13586
to look at the new patch set (#2).
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Some of the e2e tests create tables and databases on S3. HMS operations
like dropDatabaseCascade can take significant time (3-5 min) in such
tests. If the HMS Client times out, it retries for a configurable number
of times. Unfortunately, HMS client is not smart enough to understand
which operations should be retried. Eg, a drop database operation which
is timed out on the client side, should not be retried since the server
thread may have succeeded before the next retry. This would cause the
client to receive a NoSuchObjectException which would look like a flaky
test failure on the Impala side.
This patch increases the metastore client.socket.timeout for
the tests so that such flaky test failures are reduced.
Note:
1. The timeout value of 5 min was chosen based on looking at logs for
one such failure where the HMS API took about 3.5 min. Once this patch
is deployed we should continue to see if such failures reoccur and
readjust the client timeout value accordingly.
Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13586/2
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py
File fe/src/test/resources/hive-site.xml.py:
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py@36
PS2, Line 36: retry.delay
> Ah, thanks for the explanation. It seems non-obvious enough to warrant a br
added a comment. Thanks
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:31:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13586/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13586/1//COMMIT_MSG@14
PS1, Line 14: timedout
typo: timed out
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:26:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py
File fe/src/test/resources/hive-site.xml.py:
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py@36
PS2, Line 36: retry.delay
> Does this enable retries? From the commit message I understood that we shou
It does not. This is the delay between successive retry attempts. Although this change is really unrelated to the issue, I thought of changing it since I found it unusual to have a retry delay of 0.
By default, Metastore client retries once. I don't want to disable retries just yet since I am not really sure it is indeed helpful in some cases like connectivity issues with HMS or the DB during the tests. If we see more retry related failures, then perhaps we should disable the retries.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:23:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3583/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 19:12:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
Patch Set 2:
(3 comments)
Thanks for looking into this.
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
The first line of the commit message should contain a brief description of what the change does.
Nit: Remove space before ":", see other commit messages.
http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG@23
PS2, Line 23: 5 min
Stale comment?
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py
File fe/src/test/resources/hive-site.xml.py:
http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py@36
PS2, Line 36: retry.delay
Does this enable retries? From the commit message I understood that we shouldn't retry but instead wait longer.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:00:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13586/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13586/1//COMMIT_MSG@14
PS1, Line 14: timedout
> typo: timed out
Done
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 17:48:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 2:
Carrying forward Lar's +2 from earlier.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:31:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13586
to look at the new patch set (#3).
Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
......................................................................
IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. NoSuchObjectException thrown
Some of the e2e tests create tables and databases on S3. HMS operations
like dropDatabaseCascade can take significant time (3-5 min) in such
tests. If the HMS Client times out, it retries for a configurable number
of times. Unfortunately, HMS client is not smart enough to understand
which operations should be retried. Eg, a drop database operation which
is timed out on the client side, should not be retried since the server
thread may have succeeded before the next retry. This would cause the
client to receive a NoSuchObjectException which would look like a flaky
test failure on the Impala side.
This patch increases the metastore client.socket.timeout for
the tests so that such flaky test failures are reduced.
Note:
1. The timeout value of 10 min was chosen based on looking at logs for
one such failure where the HMS API took about 3.5 min. Once this patch
is deployed we should continue to see if such failures reoccur and
readjust the client timeout value accordingly.
Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13586/3
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
IMPALA-7154: Increase metastore client time out for tests
Some of the e2e tests create tables and databases on S3. HMS operations
like dropDatabaseCascade can take significant time (3-5 min) in such
tests. If the HMS Client times out, it retries for a configurable number
of times. Unfortunately, HMS client is not smart enough to understand
which operations should be retried. Eg, a drop database operation which
is timedout on the client side, should not be retried since the server
thread may have succeeded before the next retry. This would cause the
client to receive a NoSuchObjectException which would look like a flaky
test failure on the Impala side.
This patch increases the metastore client.socket.timeout for
the tests so that such flaky test failures are reduced.
Note:
1. The timeout value of 10 min was chosen based on looking at logs for
one such failure where the HMS API took about 3.5 min. Once this patch
is deployed we should continue to see if such failures reoccur and
readjust the client timeout value accordingly.
Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/13586/5
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:36:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:27:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4457/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:36:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 00:07:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7154: Increase metastore client time out for tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13586 )
Change subject: IMPALA-7154: Increase metastore client time out for tests
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3582/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 19:10:08 +0000
Gerrit-HasComments: No