You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/05 14:00:18 UTC
[GitHub] [incubator-nuttx] iceaway opened a new pull request #975: Hdc1008 sensor driver
iceaway opened a new pull request #975:
URL: https://github.com/apache/incubator-nuttx/pull/975
## Summary
New driver for the HDC1008 temperature/humidity sensor. Not sure about the copyright notice in the file header after the apache move, please let me know if I should change it.
## Impact
## Testing
Tested on a stm32f103 (bluepill) board. Example application in a separate pull request to the apps repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #975: Hdc1008 sensor driver
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #975:
URL: https://github.com/apache/incubator-nuttx/pull/975#discussion_r420170137
##########
File path: drivers/sensors/hdc1008.c
##########
@@ -0,0 +1,1024 @@
+/****************************************************************************
+ * drivers/sensors/hdc1008.c
+ * Driver for the TI HDC1008 temperature and humidity sensor
+ *
+ * Copyright (C) 2020 Pelle Windestam. All rights reserved.
+ * Author: Pelle Windestam <pe...@windestam.se>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/
Review comment:
Sorry, but as an Apache project, all new files must have the Apache 2.0 header. Could you please copy/paste the header from, sched/sched/sched_getcpu.c? No copyrights or authors in the the Apache header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #975: Hdc1008 sensor driver
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #975:
URL: https://github.com/apache/incubator-nuttx/pull/975#issuecomment-624224756
I don't think we need to wait for all of the PR checks. They all passed last time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #975: Hdc1008 sensor driver
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #975:
URL: https://github.com/apache/incubator-nuttx/pull/975#discussion_r420169581
##########
File path: include/nuttx/sensors/hdc1008.h
##########
@@ -0,0 +1,109 @@
+/****************************************************************************
+ * include/nuttx/sensors/hdc1008.h
+ *
+ * Copyright (C) 2020 Pelle Windestam. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ****************************************************************************/
Review comment:
Sorry, but as an Apache project, all new files must have the Apache 2.0 header. Could you please copy/paste the header from, sched/sched/sched_getcpu.c? No copyrights or authors in the the Apache header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] iceaway commented on pull request #975: Hdc1008 sensor driver
Posted by GitBox <gi...@apache.org>.
iceaway commented on pull request #975:
URL: https://github.com/apache/incubator-nuttx/pull/975#issuecomment-624209071
Both files have been updated with the apache 2.0 header, please check again if it looks ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #975: Hdc1008 sensor driver
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #975:
URL: https://github.com/apache/incubator-nuttx/pull/975#issuecomment-624222440
>
>
> Both files have been updated with the apache 2.0 header, please check again if it looks ok.
Thank! I will merge when the checks compelte.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org