[GitHub] nifi pull request #2442: NIFI-4395 GenerateTableFetch can't fetch column typ...

[yjhyjhyjh0 <gi...@git.apache.org>]

GitHub user yjhyjhyjh0 opened a pull request:

    https://github.com/apache/nifi/pull/2442

    NIFI-4395 GenerateTableFetch can't fetch column type by state after i…

    …nstance reboot
    
    Add multiple states recover
    
    Add support for multiple state cache recover after instance reboot.
    Current fix by add condition for column type not found to re-cache.
    Also add unit test for multiple state recover situation.
    
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yjhyjhyjh0/nifi NIFI-4395

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2442
    
----
commit 4a3a212d218cf524f00f01d18f4e9d9fdf9ed403
Author: Deon Huang <yj...@...>
Date:   2018-01-29T15:29:21Z

    NIFI-4395 GenerateTableFetch can't fetch column type by state after instance reboot
    
    Add multiple states recover

----


---

[GitHub] nifi pull request #2442: NIFI-4395 GenerateTableFetch can't fetch column typ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2442


---

[GitHub] nifi issue #2442: NIFI-4395 GenerateTableFetch can't fetch column type by st...

[mattyb149 <gi...@git.apache.org>]

Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/2442
  
    +1 LGTM, ran the unit tests and tried on a live NiFi instance, verified the issue with the "underpopulated" column type map is resolved. Thanks for the fix! Merging to master


---