You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bhuvaneswaran A <bh...@collab.net> on 2009/10/26 15:10:25 UTC
[PATCH] Fix elapsed time in Junit reports
As discussed in email thread [1], please find attached the patch to fix
elapsed time displayed in Hudson build system. It also deals with
milliseconds.
[[
Rightly process the elapsed time, including the milliseconds.
* tools/dev/gen_junit_report.py
(update_stat): Use float type while calculating the time taken for
individual tests.
(main): The seconds field may contain milli seconds, do not cast as
int type. If so, do it as float.
]]
[1]
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411335
--
Bhuvaneswaran A
CollabNet Software P Ltd. | www.collab.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411410
Re: [PATCH] Fix elapsed time in Junit reports
Posted by Bhuvaneswaran A <bh...@collab.net>.
On Mon, 2009-10-26 at 14:35 -0400, Mark Phippard wrote:
> On Mon, Oct 26, 2009 at 11:32 AM, Bhuvaneswaran A <bh...@collab.net> wrote:
> > On Mon, 2009-10-26 at 11:19 -0400, Mark Phippard wrote:
> >> This looks OK. I assume you need to commit the other change first or together?
> >
> > Mark, this can be committed separately. Both these patches fix 2
> > different issues.
>
> Sorry, that was a +1 to commit.
Committed in r40228. Thank you.
--
Bhuvaneswaran A
CollabNet Software P Ltd. | www.collab.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411565
Re: [PATCH] Fix elapsed time in Junit reports
Posted by Mark Phippard <ma...@gmail.com>.
On Mon, Oct 26, 2009 at 11:32 AM, Bhuvaneswaran A <bh...@collab.net> wrote:
> On Mon, 2009-10-26 at 11:19 -0400, Mark Phippard wrote:
>> This looks OK. I assume you need to commit the other change first or together?
>
> Mark, this can be committed separately. Both these patches fix 2
> different issues.
Sorry, that was a +1 to commit.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411478
Re: [PATCH] Fix elapsed time in Junit reports
Posted by Bhuvaneswaran A <bh...@collab.net>.
On Mon, 2009-10-26 at 11:19 -0400, Mark Phippard wrote:
> This looks OK. I assume you need to commit the other change first or together?
Mark, this can be committed separately. Both these patches fix 2
different issues.
Thank you.
> On Mon, Oct 26, 2009 at 11:10 AM, Bhuvaneswaran A <bh...@collab.net> wrote:
> > As discussed in email thread [1], please find attached the patch to fix
> > elapsed time displayed in Hudson build system. It also deals with
> > milliseconds.
> >
> > [[
> > Rightly process the elapsed time, including the milliseconds.
> >
> > * tools/dev/gen_junit_report.py
> > (update_stat): Use float type while calculating the time taken for
> > individual tests.
> > (main): The seconds field may contain milli seconds, do not cast as
> > int type. If so, do it as float.
> > ]]
> >
> > [1]
> > http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411335
> >
> > --
> > Bhuvaneswaran A
> > CollabNet Software P Ltd. | www.collab.net
> >
> > ------------------------------------------------------
> > http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411410
>
>
>
--
Bhuvaneswaran A
CollabNet Software P Ltd. | www.collab.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411433
Re: [PATCH] Fix elapsed time in Junit reports
Posted by Mark Phippard <ma...@gmail.com>.
This looks OK. I assume you need to commit the other change first or together?
On Mon, Oct 26, 2009 at 11:10 AM, Bhuvaneswaran A <bh...@collab.net> wrote:
> As discussed in email thread [1], please find attached the patch to fix
> elapsed time displayed in Hudson build system. It also deals with
> milliseconds.
>
> [[
> Rightly process the elapsed time, including the milliseconds.
>
> * tools/dev/gen_junit_report.py
> (update_stat): Use float type while calculating the time taken for
> individual tests.
> (main): The seconds field may contain milli seconds, do not cast as
> int type. If so, do it as float.
> ]]
>
> [1]
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411335
>
> --
> Bhuvaneswaran A
> CollabNet Software P Ltd. | www.collab.net
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411410
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411412