You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ammachado (via GitHub)" <gi...@apache.org> on 2026/05/21 14:43:26 UTC
[PR] CAMEL-22894: Extract collection functions into CollectionFunctionFactory [camel]
ammachado opened a new pull request, #23432:
URL: https://github.com/apache/camel/pull/23432
# Description
Extracts 16 collection-related functions from the monolithic `SimpleFunctionExpression` into a dedicated `CollectionFunctionFactory` implementing `SimpleLanguageFunctionFactory`.
Functions moved: `setHeader`, `setVariable`, `range`, `distinct`, `reverse`, `shuffle`, `split`, `sort`, `forEach`, `filter`, `listAdd`, `listRemove`, `mapAdd`, `mapRemove`, `list`, `map`.
This is a follow-up to the previous PR that extracted math and string functions. The refactoring continues reducing `SimpleFunctionExpression` by removing approximately 600 lines.
**Cleanup included:** removes a duplicate `distinct` block in `createCodeExpressionMisc` that was dead code (unreachable because `distinct` was already matched earlier in the same method).
**Known pre-existing inconsistency preserved (not fixed here):** the `range` function behaves differently between the expression and code-gen paths — the expression path defaults `min` to `"1"` while the code-gen path defaults `min` to `0`. Both behaviors are preserved unchanged to avoid introducing regressions.
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
_Claude Code on behalf of Adriano Machado_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22894: Extract collection functions into CollectionFunctionFactory [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23432:
URL: https://github.com/apache/camel/pull/23432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22894: Extract collection functions into CollectionFunctionFactory [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23432:
URL: https://github.com/apache/camel/pull/23432#issuecomment-4510783810
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22894: Extract collection functions into CollectionFunctionFactory [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23432:
URL: https://github.com/apache/camel/pull/23432#issuecomment-4510949236
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `core/camel-core-languages`
- `core/camel-core`
> :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
:warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
- `core/camel-core`: 2 test(s) disabled on GitHub Actions
<details><summary>Build reactor — dependencies compiled but only changed modules were tested (2 modules)</summary>
- Camel :: Core
- Camel :: Core Languages
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26233210436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org