You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/29 22:23:11 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #2814: Fix nullability calculation for `CASE` expressions

alamb opened a new pull request, #2814:
URL: https://github.com/apache/arrow-datafusion/pull/2814

   # Which issue does this PR close?
   
   Part of https://github.com/apache/arrow-datafusion/pull/2778
   
    # Rationale for this change
   
   https://github.com/apache/arrow-rs/issues/1888 (added in `arrow 17.0.0`) added validation to `RecordBatch` if the schema's declared nullability is different than its actual nullability it throws a runtime error. 
   
   # What changes are included in this PR?
   Correct declared schema nullability calculation for `CASE` expressions
   
   There are no tests in this PR -- they are covered in https://github.com/apache/arrow-datafusion/pull/2778
   
   # Are there any user-facing changes?
   Yes the output schema  calculation for CASE expressions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] liukun4515 merged pull request #2814: Fix nullability calculation for `CASE` expressions

Posted by GitBox <gi...@apache.org>.
liukun4515 merged PR #2814:
URL: https://github.com/apache/arrow-datafusion/pull/2814


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2814: Fix nullability calculation for `CASE` expressions

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2814:
URL: https://github.com/apache/arrow-datafusion/pull/2814#discussion_r910459248


##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -170,7 +170,10 @@ impl ExprSchemable for Expr {
                 } else if let Some(e) = else_expr {
                     e.nullable(input_schema)
                 } else {
-                    Ok(false)
+                    println!("AAL IN none else expr");

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org