[jira] [Commented] (HADOOP-13257) Improve Azure Data Lake contract tests.

["Vishwajeet Dusane (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712275#comment-15712275 ] 

Vishwajeet Dusane commented on HADOOP-13257:
--------------------------------------------

Thanks [~liuml07] for taking some time to review and the feedback.

{quote}
1. I don't have a Azure subscription;did you finish a successful full test run integrated against the Azure Data Lake back-end with this patch?
{quote}
i do have internal Jenkins setup to execute contract test periodically against Azure Data Lake back-end. All test are passing consistently. This patch do have dependency on HDFS-11132. [~stevel@apache.org] has a support for the change, Could [~stevel@apache.org], [~chris.douglas], [~cnauroth] or [~liuml07] please commit HDFS-11132, in case no further comment to address HDFS-11132 to unblock this patch.

{quote}
2. In TestAdlSupportedCharsetInPath, is failureReport ever reported? Naming private helper ...
{quote}

Good catch, {{failureReport}} is no longer needed. I had added it earlier to get collective report after concurrent test execution. So as {{assertTrue}} and {{assertFalse}}. I will incorporate the comment and update patch.

{quote}
3. In the TestMetadata.java, we can make the parent a static variable as it's used in all test cases.
{quote}
Yes, I will make parent as member variable to limit its scope to {{TestMetadata.java}}.

{quote}
6. When generating Parameterized.Parameters, can we use loops? They're clearer for covering different cases.
{quote}
Sorry i doubt if i understood the comment, Could you please clarify?

{quote}
7. The follow methods can be simplified
{quote}
Initially i had the simplified version of the code you proposed. Issue faced, output was flood with logs since {{TestAdlSupportedCharsetInPath}} has 470+ test. Hence added check to dump the log only when not found.
 
{quote}
Checkstyle warnings are related if you run ...
{quote}
Ohh i missed to see these warning, i noticed +1 from jenkins and ignore to read through the report. Thanks [~liuml07] for highlighting.



> Improve Azure Data Lake contract tests.
> ---------------------------------------
>
>                 Key: HADOOP-13257
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13257
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Chris Nauroth
>            Assignee: Vishwajeet Dusane
>         Attachments: HADOOP-13257.001.patch
>
>
> HADOOP-12875 provided the initial implementation of the FileSystem contract tests covering Azure Data Lake.  This issue tracks subsequent improvements on those test suites for improved coverage and matching the specified semantics more closely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org