You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/17 12:26:13 UTC
[GitHub] [skywalking-booster-ui] techbirds opened a new pull request, #171: feat: added name verification for dashboard to avoid creating blanks…
techbirds opened a new pull request, #171:
URL: https://github.com/apache/skywalking-booster-ui/pull/171
added name verification for new dashboard to avoid creating blanks when page blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #171: fix: added name verification for dashboard to avoid creating blanks…
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #171:
URL: https://github.com/apache/skywalking-booster-ui/pull/171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #171: feat: added name verification for dashboard to avoid creating blanks…
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on code in PR #171:
URL: https://github.com/apache/skywalking-booster-ui/pull/171#discussion_r997028148
##########
src/views/dashboard/New.vue:
##########
@@ -81,6 +81,10 @@ const onCreate = () => {
states.entity === d.entity &&
states.selectedLayer === d.layer
);
+ if (states.name.trim() === "") {
+ ElMessage.error(t("nameEmptyError"));
+ return;
+ }
Review Comment:
```suggestion
if (!states.name) {
ElMessage.error(t("nameEmptyError"));
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #171: fix: added name verification for dashboard to avoid creating blanks…
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on code in PR #171:
URL: https://github.com/apache/skywalking-booster-ui/pull/171#discussion_r997057781
##########
src/views/dashboard/New.vue:
##########
@@ -81,6 +81,10 @@ const onCreate = () => {
states.entity === d.entity &&
states.selectedLayer === d.layer
);
+ if (!states.name) {
Review Comment:
> does this cover the name only includes whitespace?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #171: fix: added name verification for dashboard to avoid creating blanks…
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #171:
URL: https://github.com/apache/skywalking-booster-ui/pull/171#discussion_r997053634
##########
src/views/dashboard/New.vue:
##########
@@ -81,6 +81,10 @@ const onCreate = () => {
states.entity === d.entity &&
states.selectedLayer === d.layer
);
+ if (!states.name) {
Review Comment:
I noticed this would use `trim`, does this cover the name only includes whitespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org