You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2010/11/16 12:57:48 UTC

svn commit: r1035602 - /james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java

Author: norman
Date: Tue Nov 16 11:57:48 2010
New Revision: 1035602

URL: http://svn.apache.org/viewvc?rev=1035602&view=rev
Log:
Done use a statistics plugin for getting the size of a queue because there is a bug in ActiveMQ. Thats a workaround for JAMES-1133

Modified:
    james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java

Modified: james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java
URL: http://svn.apache.org/viewvc/james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java?rev=1035602&r1=1035601&r2=1035602&view=diff
==============================================================================
--- james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java (original)
+++ james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java Tue Nov 16 11:57:48 2010
@@ -294,10 +294,16 @@ public class ActiveMQMailQueue extends J
     /**
      * Try to use ActiveMQ StatisticsPlugin to get size and if that fails fallback to {@link JMSMailQueue#getSize()}
      * 
+     * TODO:    This needs to get enabled again. At the moment we just fallback to super method because of a MemoryLeak in AMQ.
+     *          See: https://issues.apache.org/activemq/browse/AMQ-3041
+     * 
      */
     @Override
     public long getSize() throws MailQueueException {
         
+        /**
+         * 
+         
         Connection connection = null;
         Session session = null;
         MessageConsumer consumer = null;
@@ -388,6 +394,8 @@ public class ActiveMQMailQueue extends J
         }    
         
         // if we came to this point we should just fallback to super method
+          
+        */ 
         return super.getSize();
     }
     



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org