You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/22 23:56:12 UTC

Review Request 64822: Made protobuf version 3+ a hard requirement for building Mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64822/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jie Yu.


Repository: mesos


Description
-------

Made protobuf version 3+ a hard requirement for building Mesos.


Diffs
-----

  configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348 


Diff: https://reviews.apache.org/r/64822/diff/1/


Testing
-------

Tested the following cases:
`../configure --with-protobuf=/opt/protobuf-2.6.1 --disable-java --disable-python` => Failure
`../configure --with-protobuf=/opt/protobuf-3.3.0 --disable-java --disable-python` => Success


Thanks,

Chun-Hung Hsiao


Re: Review Request 64822: Made protobuf version 3+ a hard requirement for building Mesos.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64822/#review194467
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 22, 2017, 11:56 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64822/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2017, 11:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made protobuf version 3+ a hard requirement for building Mesos.
> 
> 
> Diffs
> -----
> 
>   configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348 
> 
> 
> Diff: https://reviews.apache.org/r/64822/diff/1/
> 
> 
> Testing
> -------
> 
> Tested the following cases:
> `../configure --with-protobuf=/opt/protobuf-2.6.1 --disable-java --disable-python` => Failure
> `../configure --with-protobuf=/opt/protobuf-3.3.0 --disable-java --disable-python` => Success
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>