[GitHub] [druid] rohangarg commented on a change in pull request #11280: bitwise aggregators, better null handling options for expression agg

[GitBox <gi...@apache.org>]

rohangarg commented on a change in pull request #11280:
URL: https://github.com/apache/druid/pull/11280#discussion_r652594161



##########
File path: processing/src/main/java/org/apache/druid/query/aggregation/ExpressionLambdaAggregator.java
##########
@@ -29,12 +29,19 @@
   private final Expr lambda;
   private final ExpressionLambdaAggregatorInputBindings bindings;
   private final int maxSizeBytes;
+  private boolean uninitializedNullValue;
 
-  public ExpressionLambdaAggregator(Expr lambda, ExpressionLambdaAggregatorInputBindings bindings, int maxSizeBytes)
+  public ExpressionLambdaAggregator(
+      final Expr lambda,
+      final ExpressionLambdaAggregatorInputBindings bindings,
+      final boolean initiallyNull,
+      final int maxSizeBytes
+  )
   {
     this.lambda = lambda;
     this.bindings = bindings;
     this.maxSizeBytes = maxSizeBytes;
+    this.uninitializedNullValue = initiallyNull;

Review comment:
       I would suggest to name this as `useNullIfUninitialized` for clarity - the current name didn't seem like a boolean question to me. I would also prefer any other better name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org