You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/12 04:44:49 UTC
[GitHub] [solr] dsmiley opened a new pull request #517: SOLR-14686 Remove log "[coreName]" (logid) which is redundant with MDC
dsmiley opened a new pull request #517:
URL: https://github.com/apache/solr/pull/517
https://issues.apache.org/jira/browse/SOLR-14686
Tests pass.
@joel-bernstein I'm hoping you could take a look here as you've worked on the SolrLogPostTool. I noticed the test expects a newSearcher to not have MDC but I suspect that's not the case these days?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #517: SOLR-14686 Remove log "[coreName]" (logid) which is redundant with MDC
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #517:
URL: https://github.com/apache/solr/pull/517#issuecomment-1010633192
FYI most of the PR was done quite a while ago in the lucene-solr repo where there are still some comments I left on some of the changes: https://github.com/apache/lucene-solr/pull/1703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #517: SOLR-14686 Remove log "[coreName]" (logid) which is redundant with MDC
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #517:
URL: https://github.com/apache/solr/pull/517#discussion_r782760607
##########
File path: solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java
##########
@@ -222,9 +222,14 @@ public void addToLog(String name, Object val) {
return toLog;
}
- /** Returns a string of the form "logid name1=value1 name2=value2 ..." */
- public String getToLogAsString(String logid) {
- StringBuilder sb = new StringBuilder(logid);
+ /** @see #getToLogAsString(String) */
Review comment:
*MissingSummary:* A summary fragment is required; consider using the value of the @see block as a summary fragment instead. [(details)](https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #517: SOLR-14686 Remove log "[coreName]" (logid) which is redundant with MDC
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #517:
URL: https://github.com/apache/solr/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org