You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/10 03:04:10 UTC
[GitHub] [cordova-plugin-statusbar] breautek opened a new pull request #190: Removed iOS 7+
breautek opened a new pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
docs
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
"Supported platforms iOS 7+" suggested we supported iOS 7 which we don't. We can instead just generically mention iOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] breautek edited a comment on pull request #190: docs: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190#issuecomment-642030556
> I am now thinking that they are showing supported platforms and sometimes minimum platform versions per feature.
They are. My rationale is, if a minimum supported feature is less than of what what the latest version platform version supports, then we probably should omit the version, or at the very least raise the min version documented to what the latest version of the latest platform supports. For example, `cordova-ios@6` supports `iOS 11` at minimum. This could be confusing for anybody using an older version of the platform, but we generally don't support old versions of our packages anyway?
On the other hand, the actual minimum version that a particular feature could be useful I guess if you're using an older version of a platform. Maybe it's okay just to leave it as is and abandoned this PR... but I just found it weird to see "iOS 7+" supported platforms when none of our recent cordova-ios versions don't even support iOS 7. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] breautek merged pull request #190: docs: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] brodybits commented on a change in pull request #190: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190#discussion_r437835928
##########
File path: README.md
##########
@@ -153,7 +153,7 @@ Set to true to make the statusbar overlay on top of your app. Ensure that you ad
Supported Platforms
-------------------
-- iOS 7+
+- iOS
- Android 5+
Review comment:
```suggestion
- Android
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] breautek commented on pull request #190: docs: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190#issuecomment-649739950
Thanks for the approvals.
The failed check is a disrepency, on travis dashboard, it shows everything is passing https://travis-ci.org/github/apache/cordova-plugin-statusbar (plus this is just a doc change, not a code change anyway).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] breautek commented on pull request #190: docs: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190#issuecomment-642030556
> I am now thinking that they are showing supported platforms and sometimes minimum platform versions per feature.
They are. My rationale is, if a minimum supported feature is less than of what what the latest version platform version supports, then we probably should omit the version, or at the very least raise the min version documented to what the latest version of the latest platform supports. For example, `cordova-ios@6` supports `iOS 11` at minimum.
On the other hand, the actual minimum version that a particular feature could be useful I guess if you're using an older version of a platform. Maybe it's okay just to leave it as is and abandoned this PR... but I just found it weird to see "iOS 7+" supported platforms when none of our recent cordova-ios versions don't even support iOS 7. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] breautek commented on pull request #190: docs: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190#issuecomment-649654264
> But I wouldn't change the 5+ for Android, since cordova-android 9 is not out yet, and even if it was, the plugin doesn't require cordova-android 9 to work.
I tend to agree, which is why I didn't originally touched it. @brodybits is it okay I revert this https://github.com/apache/cordova-plugin-statusbar/pull/190/commits/12519643465089630a4395b923cd8a219f7baf13?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] brodybits commented on pull request #190: docs: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
brodybits commented on pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190#issuecomment-649661519
> @brodybits is it okay I revert this [1251964](https://github.com/apache/cordova-plugin-statusbar/commit/12519643465089630a4395b923cd8a219f7baf13)?
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] jcesarmobile commented on pull request #190: docs: Removed iOS 7+
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #190:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/190#issuecomment-649633626
I think iOS 7+ can be removed, since it's only specified in one method now, so looks like it should have been removed when it was removed in the other methods, but was missed.
But I wouldn't change the 5+ for Android, since cordova-android 9 is not out yet, and even if it was, the plugin doesn't require cordova-android 9 to work. And also it's used in multiple places, but only removed in one of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org