You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2016/12/13 07:47:24 UTC
svn commit: r1773928 - in /directory/shared/trunk:
dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/
dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/
ldap/client/api/src/main/java/org/apache/directory/ldap/client/tem...
Author: elecharny
Date: Tue Dec 13 07:47:23 2016
New Revision: 1773928
URL: http://svn.apache.org/viewvc?rev=1773928&view=rev
Log:
Cleared some SonarLint warnings and fixed some typoes
Modified:
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbandonRequestDsml.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractRequestDsml.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractResultResponseRequestDsml.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/BatchRequestDsml.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/AbstractResultResponseDsml.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/BatchResponseDsml.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/ErrorResponse.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/LdapResultDsml.java
directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/SearchResponseDsml.java
directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java
directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java
directory/shared/trunk/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerUtils.java
directory/shared/trunk/ldap/extras/util/src/main/java/org/apache/directory/api/ldap/util/JndiUtils.java
directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbandonRequestDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbandonRequestDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbandonRequestDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbandonRequestDsml.java Tue Dec 13 07:47:23 2016
@@ -78,7 +78,7 @@ public class AbandonRequestDsml extends
// AbandonID
if ( getDecorated().getAbandoned() != 0 )
{
- element.addAttribute( "abandonID", "" + getDecorated().getAbandoned() );
+ element.addAttribute( "abandonID", Integer.toString( getDecorated().getAbandoned() ) );
}
return element;
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractRequestDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractRequestDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractRequestDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractRequestDsml.java Tue Dec 13 07:47:23 2016
@@ -67,7 +67,7 @@ public abstract class AbstractRequestDsm
int requestID = getDecorated().getMessageId();
if ( requestID > 0 )
{
- element.addAttribute( "requestID", "" + requestID );
+ element.addAttribute( "requestID", Integer.toString( requestID ) );
}
// Controls
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractResultResponseRequestDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractResultResponseRequestDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractResultResponseRequestDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/AbstractResultResponseRequestDsml.java Tue Dec 13 07:47:23 2016
@@ -72,7 +72,7 @@ public abstract class AbstractResultResp
int requestID = getDecorated().getMessageId();
if ( requestID > 0 )
{
- element.addAttribute( "requestID", "" + requestID );
+ element.addAttribute( "requestID", Integer.toString( requestID ) );
}
// Controls
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/BatchRequestDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/BatchRequestDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/BatchRequestDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/request/BatchRequestDsml.java Tue Dec 13 07:47:23 2016
@@ -282,7 +282,7 @@ public class BatchRequestDsml
// RequestID
if ( requestID != 0 )
{
- element.addAttribute( "requestID", "" + requestID );
+ element.addAttribute( "requestID", Integer.toString( requestID ) );
}
// ResponseOrder
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/AbstractResultResponseDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/AbstractResultResponseDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/AbstractResultResponseDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/AbstractResultResponseDsml.java Tue Dec 13 07:47:23 2016
@@ -23,7 +23,6 @@ package org.apache.directory.api.dsmlv2.
import org.apache.directory.api.ldap.codec.api.LdapApiService;
import org.apache.directory.api.ldap.model.message.LdapResult;
import org.apache.directory.api.ldap.model.message.ResultResponse;
-import org.dom4j.Element;
/**
@@ -49,12 +48,6 @@ public abstract class AbstractResultResp
/**
- * {@inheritDoc}
- */
- public abstract Element toDsml( Element root );
-
-
- /**
* {@inheritDoc}
*/
public LdapResult getLdapResult()
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/BatchResponseDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/BatchResponseDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/BatchResponseDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/BatchResponseDsml.java Tue Dec 13 07:47:23 2016
@@ -154,7 +154,7 @@ public class BatchResponseDsml
// RequestID
if ( requestID != 0 )
{
- element.addAttribute( "requestID", "" + requestID );
+ element.addAttribute( "requestID", Integer.toString( requestID ) );
}
for ( DsmlDecorator<? extends Response> response : responses )
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/ErrorResponse.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/ErrorResponse.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/ErrorResponse.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/ErrorResponse.java Tue Dec 13 07:47:23 2016
@@ -138,7 +138,7 @@ public class ErrorResponse extends Abstr
// RequestID
if ( requestID != 0 )
{
- element.addAttribute( "requestID", "" + requestID );
+ element.addAttribute( "requestID", Integer.toString( requestID ) );
}
// Type
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/LdapResultDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/LdapResultDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/LdapResultDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/LdapResultDsml.java Tue Dec 13 07:47:23 2016
@@ -77,7 +77,7 @@ public class LdapResultDsml implements D
int requestID = message.getMessageId();
if ( requestID > 0 )
{
- root.addAttribute( "requestID", "" + requestID );
+ root.addAttribute( "requestID", Integer.toString( requestID ) );
}
// Matched Dn
@@ -93,12 +93,13 @@ public class LdapResultDsml implements D
// ResultCode
Element resultCodeElement = root.addElement( "resultCode" );
- resultCodeElement.addAttribute( "code", "" + result.getResultCode().getResultCode() );
+ resultCodeElement.addAttribute( "code", Integer.toString( result.getResultCode().getResultCode() ) );
resultCodeElement.addAttribute( "descr", result.getResultCode().getMessage() );
// ErrorMessage
String errorMessage = ( result.getDiagnosticMessage() );
- if ( ( errorMessage != null ) && ( !errorMessage.equals( "" ) ) )
+
+ if ( ( errorMessage != null ) && ( errorMessage.length() != 0 ) )
{
Element errorMessageElement = root.addElement( "errorMessage" );
errorMessageElement.addText( errorMessage );
Modified: directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/SearchResponseDsml.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/SearchResponseDsml.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/SearchResponseDsml.java (original)
+++ directory/shared/trunk/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/response/SearchResponseDsml.java Tue Dec 13 07:47:23 2016
@@ -165,7 +165,7 @@ public class SearchResponseDsml extends
int requestID = getDecorated().getMessageId();
if ( requestID > 0 )
{
- element.addAttribute( "requestID", "" + requestID );
+ element.addAttribute( "requestID", Integer.toString( requestID ) );
}
}
Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java (original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java Tue Dec 13 07:47:23 2016
@@ -66,6 +66,9 @@ final class PasswordWarningImpl implemen
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public int getTimeBeforeExpiration()
{
@@ -73,6 +76,9 @@ final class PasswordWarningImpl implemen
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public int getGraceAuthNsRemaining()
{
@@ -80,6 +86,9 @@ final class PasswordWarningImpl implemen
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public boolean isChangeAfterReset()
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java Tue Dec 13 07:47:23 2016
@@ -29,9 +29,9 @@ import org.apache.directory.api.ldap.mod
* The codec uses this interface to add additional information to LDAP Model
* Control objects during encoding and decoding.
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
- *
* @param <E> The control being handled by this codec
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public interface CodecControl<E extends Control> extends Control, Decorator<E>
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java Tue Dec 13 07:47:23 2016
@@ -29,8 +29,9 @@ import org.apache.directory.api.ldap.mod
* then registered with the codec and used by the codec to encode and decode
* those controls.
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <C> The Control to create
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public interface ControlFactory<C extends Control>
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java Tue Dec 13 07:47:23 2016
@@ -29,8 +29,9 @@ import org.apache.directory.api.asn1.Enc
* The codec uses this interface to add additional information to LDAP Model
* objects during encoding and decoding,
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <E> The element to decorate
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public interface Decorator<E>
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java Tue Dec 13 07:47:23 2016
@@ -35,8 +35,9 @@ import org.apache.directory.api.util.Str
/**
* A decorator for the ExtendedRequest message
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <Q> The extended request to decorate
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public class ExtendedRequestDecorator<Q extends ExtendedRequest>
extends SingleReplyRequestDecorator<Q> implements ExtendedRequest
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java Tue Dec 13 07:47:23 2016
@@ -35,8 +35,9 @@ import org.apache.directory.api.util.Str
/**
* A decorator for the ExtendedResponse message
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <R> The extended response to decorate
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public class ExtendedResponseDecorator<R extends ExtendedResponse> extends ResponseDecorator<R>
implements ExtendedResponse
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java Tue Dec 13 07:47:23 2016
@@ -32,8 +32,9 @@ import org.apache.directory.api.ldap.mod
* When dealing with an encoding PDU, we will obtain a LdapMessage in the
* container.
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <E> The decorated message
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public class LdapMessageContainer<E extends MessageDecorator<? extends Message>> extends AbstractContainer
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java Tue Dec 13 07:47:23 2016
@@ -72,8 +72,9 @@ import org.apache.directory.api.ldap.mod
/**
* A decorator for the generic LDAP Message
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <E> The message to decorate
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public abstract class MessageDecorator<E extends Message> implements Message, Decorator<E>, Asn1Object
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java Tue Dec 13 07:47:23 2016
@@ -27,7 +27,7 @@ import org.apache.directory.api.ldap.mod
/**
- *
+ * A factory to create a PersistentSearch control
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @version $Rev$, $Date$
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java Tue Dec 13 07:47:23 2016
@@ -28,9 +28,9 @@ import org.apache.directory.api.ldap.mod
/**
* The action used to store the result code of a SortResponseControl
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
- *
* @param <C> The Asn1Container type to use
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public class StoreSortResponseResultCode<C extends Asn1Container> extends AbstractReadInteger<C>
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java Tue Dec 13 07:47:23 2016
@@ -27,10 +27,10 @@ import org.apache.directory.api.ldap.mod
/**
* A decorator for the LdapResultResponse message
- *
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*
* @param <M> The Request to decorate
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public abstract class AbandonableRequestDecorator<M extends AbandonableResultResponseRequest>
extends ResultResponseRequestDecorator<M>
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java Tue Dec 13 07:47:23 2016
@@ -27,10 +27,10 @@ import org.apache.directory.api.ldap.mod
/**
* A decorator for the LdapResultResponse message
- *
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*
* @param <M> The message response to decorate
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public abstract class AbandonableResultResponseRequestDecorator<M extends AbandonableResultResponseRequest>
extends AbandonableRequestDecorator<M> implements ResultResponseRequest
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java Tue Dec 13 07:47:23 2016
@@ -27,10 +27,10 @@ import org.apache.directory.api.ldap.mod
/**
* A decorator for the LdapResultResponse message
- *
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*
* @param <M> The request to decorate
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public abstract class RequestDecorator<M extends Request> extends MessageDecorator<M> implements Request
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java Tue Dec 13 07:47:23 2016
@@ -28,9 +28,10 @@ import org.apache.directory.api.ldap.mod
/**
* A decorator for the Response message. It will store the LdapResult.
+ *
+ * @param <M> The response to be decorated
*
* @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
- * @param <M> The response to be decorated
*/
public abstract class ResponseDecorator<M extends ResultResponse> extends MessageDecorator<M> implements ResultResponse
{
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java Tue Dec 13 07:47:23 2016
@@ -28,8 +28,9 @@ import org.apache.directory.api.ldap.mod
/**
* A decorator for the LdapResultResponse message
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <M> The request to be decorated
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public abstract class ResultResponseRequestDecorator<M extends ResultResponseRequest>
extends RequestDecorator<M> implements ResultResponseRequest
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java Tue Dec 13 07:47:23 2016
@@ -30,8 +30,9 @@ import org.apache.directory.api.ldap.mod
/**
* A decorator for the LdapResultResponse message
*
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
* @param <M> The request to be decorated
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
*/
public abstract class SingleReplyRequestDecorator<M extends SingleReplyRequest>
extends ResultResponseRequestDecorator<M> implements SingleReplyRequest, AbandonableRequest
Modified: directory/shared/trunk/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerUtils.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerUtils.java (original)
+++ directory/shared/trunk/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerUtils.java Tue Dec 13 07:47:23 2016
@@ -115,7 +115,7 @@ public final class TriggerUtils
/**
- * Load the etrigger specification entry
+ * Load the trigger specification entry
*
* @param ctx The context
* @param triggerSpec The trigger specification
Modified: directory/shared/trunk/ldap/extras/util/src/main/java/org/apache/directory/api/ldap/util/JndiUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/util/src/main/java/org/apache/directory/api/ldap/util/JndiUtils.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/util/src/main/java/org/apache/directory/api/ldap/util/JndiUtils.java (original)
+++ directory/shared/trunk/ldap/extras/util/src/main/java/org/apache/directory/api/ldap/util/JndiUtils.java Tue Dec 13 07:47:23 2016
@@ -99,6 +99,7 @@ public final class JndiUtils
* @param control The control to convert
* @return A JNDI control
* @throws EncoderException If the conversion failed
+ * @deprecated We don't use JNDI anymore
*/
@Deprecated
public static javax.naming.ldap.Control toJndiControl( LdapApiService codec, Control control )
@@ -112,8 +113,9 @@ public final class JndiUtils
* Convert some LDAP API controls to JNDI controls
* @param codec The LDAP API service to use
* @param controls The controls to convert
- * @return Aarray of JNDI control
+ * @return Array of JNDI control
* @throws EncoderException If the conversion failed
+ * @deprecated We don't use JNDI anymore
*/
@Deprecated
public static javax.naming.ldap.Control[] toJndiControls( LdapApiService codec, Control... controls )
@@ -144,6 +146,7 @@ public final class JndiUtils
* @param jndiControl The control to convert
* @return A LDAP API control
* @throws DecoderException If the conversion failed
+ * @deprecated We don't use JNDI anymore
*/
@Deprecated
public static Control fromJndiControl( LdapApiService codec, javax.naming.ldap.Control jndiControl )
@@ -157,8 +160,9 @@ public final class JndiUtils
* Convert some JNDI controls to LDAP API controls
* @param codec The LDAP API service to use
* @param jndiControls The controls to convert
- * @return An arrau of LDAP API control
+ * @return An array of LDAP API control
* @throws DecoderException If the conversion failed
+ * @deprecated We don't use JNDI anymore
*/
@Deprecated
public static Control[] fromJndiControls( LdapApiService codec, javax.naming.ldap.Control... jndiControls )
Modified: directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java?rev=1773928&r1=1773927&r2=1773928&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java (original)
+++ directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java Tue Dec 13 07:47:23 2016
@@ -154,7 +154,7 @@ public class AttributeTest
/**
- * @throws java.lang.Exception
+ * @throws Exception
*/
@BeforeClass
public static void setUpBeforeClass() throws Exception