You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jo...@apache.org on 2011/06/27 22:34:08 UTC

svn commit: r1140303 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: corelib/components/Tree.java tree/DefaultTreeModel.java

Author: joshcanfield
Date: Mon Jun 27 20:34:08 2011
New Revision: 1140303

URL: http://svn.apache.org/viewvc?rev=1140303&view=rev
Log:
TAP5-1559 - Excessive warnings

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/tree/DefaultTreeModel.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java?rev=1140303&r1=1140302&r2=1140303&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Tree.java Mon Jun 27 20:34:08 2011
@@ -113,7 +113,7 @@ public class Tree
         public void render(MarkupWriter writer, RenderQueue queue)
         {
             writer.end();
-        };
+        }
     };
 
     private static RenderCommand RENDER_LABEL_SPAN = new RenderCommand()
@@ -121,7 +121,7 @@ public class Tree
         public void render(MarkupWriter writer, RenderQueue queue)
         {
             writer.element("span", "class", "t-tree-label");
-        };
+        }
     };
 
     /**
@@ -206,7 +206,7 @@ public class Tree
         };
     }
 
-    /** Renders an <ul> element and renders each node recusively inside the element. */
+    /** Renders an <ul> element and renders each node recursively inside the element. */
     private class RenderNodes implements RenderCommand
     {
         private final Flow<TreeNode> nodes;

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/tree/DefaultTreeModel.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/tree/DefaultTreeModel.java?rev=1140303&r1=1140302&r2=1140303&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/tree/DefaultTreeModel.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/tree/DefaultTreeModel.java Mon Jun 27 20:34:08 2011
@@ -33,6 +33,7 @@ import java.util.Map;
  * @param <T>
  * @since 5.3.0
  */
+@SuppressWarnings({"UnusedDeclaration"})
 public class DefaultTreeModel<T> implements TreeModel<T>
 {
     private final ValueEncoder<T> encoder;
@@ -48,7 +49,7 @@ public class DefaultTreeModel<T> impleme
         public TreeNode<T> map(T value)
         {
             return new DefaultTreeNode(value);
-        };
+        }
     };
 
     private class DefaultTreeNode implements TreeNode<T>
@@ -101,8 +102,11 @@ public class DefaultTreeModel<T> impleme
      * Creates a new model starting from a single root element.
      * 
      * @param encoder
+     *            used to convert values to strings and vice-versa
      * @param adapter
+     *            adapts elements to the tree
      * @param root
+     *            defines the root node of the model
      */
     public DefaultTreeModel(ValueEncoder<T> encoder, TreeModelAdapter<T> adapter, T root)
     {