[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8511: Fix for BigQuery connection checks and CSV uploads

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8511: Fix for BigQuery connection checks and CSV uploads
URL: https://github.com/apache/incubator-superset/pull/8511#discussion_r346927997
 
 

 ##########
 File path: superset/db_engine_specs/base.py
 ##########
 @@ -403,6 +401,8 @@ def _allowed_file(filename: str) -> bool:
                 extension is not None and extension[1:] in config["ALLOWED_EXTENSIONS"]
             )
 
+        database = db.session.query(Database).filter_by(id=form.con.data.id).one()
 
 Review comment:
   Sure. Can do. I agree the interface is wonky here - dealing with the form object should be done at the view layer. I'll make a note to refactor the interface in a future PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org