You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Jesus CASTILLO (JIRA)" <ji...@apache.org> on 2011/04/23 19:50:05 UTC

[jira] [Created] (CAMEL-3894) Support maxdept option on File Component when recursive option is enabled

Support maxdept option on File Component when recursive option is enabled
-------------------------------------------------------------------------

                 Key: CAMEL-3894
                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
             Project: Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 2.6.0
            Reporter: Jesus CASTILLO


It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.

With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-3894:
----------------------------------

    Assignee: Tracy Snell  (was: Claus Ibsen)

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>            Assignee: Tracy Snell
>             Fix For: 2.8.0
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tracy Snell closed CAMEL-3894.
------------------------------

    Resolution: Fixed

Committed revision 1142641.

Added minDepth and maxDepth options

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>             Fix For: Future
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060350#comment-13060350 ] 

Claus Ibsen commented on CAMEL-3894:
------------------------------------

Also if you work on the ticket then assign the ticket in JIRA to your name. And dont close the ticket asap, instead mark it as resolved.

We close tickets later, for example after 6+ months.

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>             Fix For: Future
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-3894:
----------------------------------

    Assignee: Claus Ibsen  (was: Tracy Snell)

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Jesus CASTILLO (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025052#comment-13025052 ] 

Jesus CASTILLO commented on CAMEL-3894:
---------------------------------------

I like the find command as we can build complex searches with a few options. Both mindepth and maxdepth allows us to limit the search when traversing the directories tree. So, both are important although I think that maxdepth is more frequently used. In addition, I think wee need a filter that supports find style searches. I am running some test to locate all the Outbox folders in the following structure:

{code}
repositories
+ repo1
  + users
    + user1
      + Incoming
      + Inbox
      + Outbox
      + Sent Files
      + Deleted Files
    + user2
    ...
    + userN
+ repo2
...
+ repoM
{code}  

but it's hard to implement it efficiently using only the Ant filter. This could be easily done with a find command as:

{code}
find ./repositories -mindepth 4 -maxdepth 4 -type d -name Outbox
{code}

A find-like filter could have support for filetype (directory/file), filter with times (mtime, ctime, etc), permissions, etc.



> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061105#comment-13061105 ] 

Claus Ibsen commented on CAMEL-3894:
------------------------------------

Tracy you updated the wrong documentation. The file component for Camel 2.x is the file2 page, eg
https://cwiki.apache.org/confluence/display/CAMEL/File2

I have moved the documentation to the correct wiki page.

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>             Fix For: Future
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-3894:
-------------------------------

    Fix Version/s: Future
       Issue Type: New Feature  (was: Improvement)

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>             Fix For: Future
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-3894.
--------------------------------

    Resolution: Fixed

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>            Assignee: Tracy Snell
>             Fix For: 2.8.0
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Jesus CASTILLO (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesus CASTILLO updated CAMEL-3894:
----------------------------------

    Summary: Support maxdepth option on File Component when recursive option is enabled  (was: Support maxdept option on File Component when recursive option is enabled)

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Tracy Snell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059433#comment-13059433 ] 

Tracy Snell commented on CAMEL-3894:
------------------------------------

Updated docs

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>             Fix For: Future
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-3894:
-------------------------------

    Fix Version/s:     (was: Future)
                   2.8.0

Reopening to set assigne, and fix versions.

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>            Assignee: Tracy Snell
>             Fix For: 2.8.0
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023647#comment-13023647 ] 

Claus Ibsen commented on CAMEL-3894:
------------------------------------

There are both a min depth and max depth option etc. How far should we take this?

So if we set maxDepth=3, then the file consumer will only at most traverse down 3 paths.

{code}
<starting>
+ level1
  + level2
    + level3
      + level4
{code}

eg in this case the file consumer will only go down as far as level3 directory.

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reopened CAMEL-3894:
--------------------------------

      Assignee: Tracy Snell

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>            Assignee: Tracy Snell
>             Fix For: 2.8.0
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-3894) Support maxdepth option on File Component when recursive option is enabled

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060348#comment-13060348 ] 

Claus Ibsen commented on CAMEL-3894:
------------------------------------

Tracy the file component is closely tied to the ftp component. So when you add an option/feature to the file component those options is often inherited by the ftp components. So its a good idea to:

- add unit test in camel-ftp as well for the new features
- document any API changes in the GenericFileConsumer as we have 3rd party end users who extend this component and do their custom file related components (add this to the API section in the release notes). You add a new parameter to the poll method. Also remember to add javadoc for that new option.
- Also consider if its possible to avoid tampering with the API so it can be backwards comp. out of the box. But sometimes the API must change and thats okay, if its documented in the release notes.
- you may need to adjust the code in camel-ftp for this new feature. I suggest you create a new JIRA ticket for that, so we get that included either in 2.8 or the next 2.9 release.
- You may want to add validation that max >= min. 

> Support maxdepth option on File Component when recursive option is enabled
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-3894
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3894
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Jesus CASTILLO
>             Fix For: Future
>
>
> It would be great if the File component adds support for the maxdepth option just like the find command does, so we can prune the recursive directory search when recursive is enabled.
> With maxdepth we can set the levels of Directories to descend during the pollDirectory function.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira