[GitHub] [dolphinscheduler] devosend commented on a change in pull request #8701: [python] refactor yaml file parser

[GitBox <gi...@apache.org>]

devosend commented on a change in pull request #8701:
URL: https://github.com/apache/dolphinscheduler/pull/8701#discussion_r820035042



##########
File path: dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/utils/file.py
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""File util for pydolphinscheduler."""
+
+from pathlib import Path
+from typing import Optional
+
+
+def write(
+    content: str,
+    to_path: str,
+    create: Optional[bool] = True,
+    overwrite: Optional[bool] = False,
+) -> None:
+    """Write configs dict to configuration file.
+
+    :param content: The source string want to write to :param:`to_path`.
+    :param to_path: The path want to write content.
+    :param create: Whether create the file or not if it does not exist. If set ``True``
+      will create file with :param:`to_path` if path not exists, otherwise ``False``
+      will not create. Default ``True``.
+    :param overwrite: Whether overwrite the file or not if it exists. If set ``True``
+      will overwrite the exists content, otherwise ``False`` will not overwrite it. Default ``True``.
+    """
+    path = Path(to_path)
+    if create and not path.parent.exists():
+        path.parent.mkdir(parents=True)
+    if not path.exists():

Review comment:
       When create param is False and the parent path does not exist, it will raise an error.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org