You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/15 08:45:31 UTC

[GitHub] codecov-io edited a comment on issue #6380: [WIP][SIP5]Implement get_payloads for querycontext.

codecov-io edited a comment on issue #6380: [WIP][SIP5]Implement get_payloads for querycontext.
URL: https://github.com/apache/incubator-superset/pull/6380#issuecomment-438962427
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6380?src=pr&el=h1) Report
   > Merging [#6380](https://codecov.io/gh/apache/incubator-superset/pull/6380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8e2d28dd6e057a16cd621bdf32c4798a2dd7ef61?src=pr&el=desc) will **decrease** coverage by `0.76%`.
   > The diff coverage is `22.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6380/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6380?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6380      +/-   ##
   ==========================================
   - Coverage   77.24%   76.47%   -0.77%     
   ==========================================
     Files          67       67              
     Lines        9583     9727     +144     
   ==========================================
   + Hits         7402     7439      +37     
   - Misses       2181     2288     +107
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6380?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/6380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `89.47% <0%> (-5.27%)` | :arrow_down: |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/6380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `24.82% <20.3%> (-75.18%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/6380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `69.44% <38.88%> (-25.8%)` | :arrow_down: |
   | [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/6380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `75.55% <0%> (-0.11%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.96% <0%> (-0.02%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `80.56% <0%> (+0.74%)` | :arrow_up: |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6380/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `55.03% <0%> (+0.87%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6380?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6380?src=pr&el=footer). Last update [8e2d28d...689b0bc](https://codecov.io/gh/apache/incubator-superset/pull/6380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org