You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "petkostas (via GitHub)" <gi...@apache.org> on 2025/08/23 11:38:46 UTC
[PR] fix(github): fix zerotime issues for GraphQL [incubator-devlake]
petkostas opened a new pull request, #8551:
URL: https://github.com/apache/incubator-devlake/pull/8551
### Summary
GitHub GraphQL returns zero time (`&time.Time{}`) for `nullable` fields, this leads to GORM not properly handling this cases.
This PR:
- Introduces a new core helper util `NilIfZeroTime` in order to ensure that `*time.Time` fields are assigned the `nil` value.
- Fixes the relevant cases in both collectors and extractors (as existing entries in the DB should be properly handled as well).
### Does this close any open issues?
Closes #8538
### Screenshots
⚠️ Screenshots pending, as this PR has not been tested yet.
⚠️ This PR has not been tested yet, I am looking for cases to properly test the fixes ⚠️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(github): fix zerotime issues for GraphQL [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8551:
URL: https://github.com/apache/incubator-devlake/pull/8551#issuecomment-3219267043
> Hey @klesh I need to test this potentially with repo that re-produces the initial problem. I added you in case you wanted to do a first check regarding the approach. But feel free to ignore until I have tested it and removed the draft.
I see — very thoughtful, thanks for the explanation!
I’d prefer to review after the tests are done, since in most cases the behavior depends more on the 3rd-party implementation (i.e., the actual response from GitHub GraphQL) than on our code, which is relatively straightforward.
In other words, field tests are more critical here than the code review 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(github): fix zerotime issues for GraphQL [incubator-devlake]
Posted by "petkostas (via GitHub)" <gi...@apache.org>.
petkostas closed pull request #8551: fix(github): fix zerotime issues for GraphQL
URL: https://github.com/apache/incubator-devlake/pull/8551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(github): fix zerotime issues for GraphQL [incubator-devlake]
Posted by "petkostas (via GitHub)" <gi...@apache.org>.
petkostas commented on PR #8551:
URL: https://github.com/apache/incubator-devlake/pull/8551#issuecomment-3219086345
Hey @klesh
I need to test this potentially with repo that re-produces the initial problem. I added you in case you wanted to do a first check regarding the approach.
But feel free to ignore until I have tested it and removed the draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(github): fix zerotime issues for GraphQL [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8551:
URL: https://github.com/apache/incubator-devlake/pull/8551#issuecomment-3218751522
Hi @petkostas, I saw the review request this morning, but since the PR is still in draft, I wasn’t sure if it’s ready for review yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(github): fix zerotime issues for GraphQL [incubator-devlake]
Posted by "petkostas (via GitHub)" <gi...@apache.org>.
petkostas commented on PR #8551:
URL: https://github.com/apache/incubator-devlake/pull/8551#issuecomment-3319690008
Opened a new directly to repo:
https://github.com/apache/incubator-devlake/pull/8583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org