You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by NicolasPerego <gi...@git.apache.org> on 2018/01/24 20:11:14 UTC

[GitHub] logging-log4net issue #14: Add .NET Standard 2.0 build

Github user NicolasPerego commented on the issue:

    https://github.com/apache/logging-log4net/pull/14
  
    I don't think it's needed anymore with Neststandard 2.0 to modify the file "log4net.Config.XmlConfigurator" like this : https://github.com/apache/logging-log4net/blob/master/src/Config/XmlConfigurator.cs#L164, because in Netstandard 2.0 you can use "Assembly.GetCallingAssembly()".
    
    As example, it's needed to use log4net with Common.Logging (see https://github.com/net-commons/common-logging/issues/167) in ASP.NET Core 2.0.
    
    I tried successfully to remove the "#if !NETSTANDARD1_3" of the file, recompile and use the modified dll with Common.Logging and it works fine.
    
    Maybe I'm missing something here, but it maybe is a good idea to revert this change ? Thanx..


---