You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2013/05/10 21:48:20 UTC

svn commit: r1481162 - in /commons/proper/commons-parent/trunk: RELEASE-NOTES.txt pom.xml

Author: luc
Date: Fri May 10 19:48:11 2013
New Revision: 1481162

URL: http://svn.apache.org/r1481162
Log:
use an automatic detection of JDK version to trigger JaCoCo report creation

Modified:
    commons/proper/commons-parent/trunk/RELEASE-NOTES.txt
    commons/proper/commons-parent/trunk/pom.xml

Modified: commons/proper/commons-parent/trunk/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/RELEASE-NOTES.txt?rev=1481162&r1=1481161&r2=1481162&view=diff
==============================================================================
--- commons/proper/commons-parent/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/commons-parent/trunk/RELEASE-NOTES.txt Fri May 10 19:48:11 2013
@@ -14,15 +14,19 @@ o                   removed cobertura-ma
                     maven-surefire-plugin              2.13 -> 2.14.1
                     maven-surefire-report-plugin       2.13 -> 2.14.1
 
-The main change is the replacement of cobertura with JaCoCo for test coverage analysis.
-The former is not maintained anymore, has numerous bugs and is extremely slow in
-some situations (typically generating coverage reports for [math] took about 9 hours whereas
-standard tests run in about 10 minutes). One important implication is that since JaCoCo
-relies on setting an agent, then it requires at least Java 1.5 to run the tests, and it
-changes the argument line of surefire tests. If a component also needs to adapt the
-surefire command line, it must add the property ${argLine} to the argument line in order
-to preserve JaCoCo settings. An example for this is Apache Commons IO, where the maven-surefire-plugin
-setting must read as (note the use of the ${argLine} property):
+The main change is the replacement of cobertura with JaCoCo for test
+coverage analysis.  The former is not maintained anymore, has numerous
+bugs and is extremely slow in some situations (typically generating
+coverage reports for [math] took about 9 hours whereas standard tests
+run in about 10 minutes). One important implication is that since
+JaCoCo relies on setting an agent, it is triggered only if JDK used to
+run the tests is at least Java 1.5 (this is automatically detected),
+and it changes the argument line of surefire tests.  If a component
+also needs to adapt the surefire command line, it must add the
+property ${argLine} to the argument line in order to preserve JaCoCo
+settings. An example for this is Apache Commons IO, where the
+maven-surefire-plugin setting must read as (note the use of the
+${argLine} property):
 
     <plugins>
       <plugin>

Modified: commons/proper/commons-parent/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1481162&r1=1481161&r2=1481162&view=diff
==============================================================================
--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Fri May 10 19:48:11 2013
@@ -39,6 +39,9 @@ Version 29:
           jacoco-maven-plugin                      -> 0.6.2.201302030002
           maven-surefire-plugin              2.13  -> 2.14.1
           maven-surefire-report-plugin       2.13  -> 2.14.1
+
+Removed skipReports property (now JaCoCo coverage is triggered directly
+by JDK version being at least 1.5).
           
 For full details see:
 http://svn.apache.org/repos/asf/commons/proper/commons-parent/tags/commons-parent-29/RELEASE-NOTES.txt
@@ -629,10 +632,7 @@ http://svn.apache.org/repos/asf/commons/
     <profile>
       <id>reporting</id>
       <activation>
-        <property>
-          <name>skipReports</name>
-          <value>!true</value>
-        </property>
+        <jdk>[1.5,)</jdk>
       </activation>
       <build>
         <plugins>