You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/10 18:56:13 UTC
[GitHub] [spark] nafshartous opened a new pull request #28492: [SPARK-27249] Developers API for Transformers beyond UnaryTransformer
nafshartous opened a new pull request #28492:
URL: https://github.com/apache/spark/pull/28492
### What changes were proposed in this pull request?
Adding class `MultiTransformer` to allow encapsulation of a sequence of transforms.
### Why are the changes needed?
Requested in the SPARK-2749 as the current API is limiting.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running the new example
```
bin/run-example ml.MultiTransformerExample
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28492: [SPARK-27249] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28492:
URL: https://github.com/apache/spark/pull/28492#issuecomment-626372878
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28492: [SPARK-27249] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28492:
URL: https://github.com/apache/spark/pull/28492#issuecomment-626373695
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28492: [SPARK-27249] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28492:
URL: https://github.com/apache/spark/pull/28492#issuecomment-626372878
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28492: [SPARK-27249][ML] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28492:
URL: https://github.com/apache/spark/pull/28492#issuecomment-674555705
All of this seems not-crazy but not necessary in Spark, and I do not see there's much general use case for it. Users can implement custom Transformers exactly as they need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nafshartous commented on pull request #28492: [SPARK-27249][ML] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
nafshartous commented on pull request #28492:
URL: https://github.com/apache/spark/pull/28492#issuecomment-674558385
That makes sense. I did inquire on the dev list before starting to work on this Jira ticket (nobody replied). Maybe it would be helpful if superfluous Jira tickedts could be periodically closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28492: [SPARK-27249][ML] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28492:
URL: https://github.com/apache/spark/pull/28492#issuecomment-674560506
They are, very asynchronously, as are PRs. That's good, but there is also push back on prematurely closing tickets - hey what do you mean you don't like my idea, why won't you let someone work on it, etc. I favor earlier closing as it's at least decisive if not guaranteed to be correct, but at least its reversible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nafshartous closed pull request #28492: [SPARK-27249][ML] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
nafshartous closed pull request #28492:
URL: https://github.com/apache/spark/pull/28492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nafshartous commented on pull request #28492: [SPARK-27249][ML] Developers API for Transformers beyond UnaryTransformer
Posted by GitBox <gi...@apache.org>.
nafshartous commented on pull request #28492:
URL: https://github.com/apache/spark/pull/28492#issuecomment-642293534
@srowen Please review Everett Rush's comment in the ticket today and advise.
https://issues.apache.org/jira/browse/SPARK-27249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org