You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ai-yang (via GitHub)" <gi...@apache.org> on 2026/09/11 11:56:36 UTC
Re: [PR] [ISSUE #10696] Fix async request future cleanup on synchronous send failure [rocketmq]
ai-yang commented on PR #10697:
URL: https://github.com/apache/rocketmq/pull/10697#issuecomment-5634069651
Refreshed onto `develop` at `1a50c6e4e` and pushed signed-off commit `e340eb4d4`.
Resolved the import conflict in `DefaultMQProducerImplTest` by retaining both the upstream `EndTransactionRequestHeader` and regression-test `After` imports. The request-future cleanup implementation is unchanged by the rebase.
Clean JDK 8 verification: `mvn -pl client -am -DskipITs -Dtest=DefaultMQProducerTest,DefaultMQProducerImplTest -Dsurefire.failIfNoSpecifiedTests=false clean test` passed 78/78 tests across the two classes. All 4 reactor modules passed with Checkstyle and SpotBugs enabled. The PR description now distinguishes this latest run from earlier full-reactor evidence.
@drpmma @RongtongJin, could you take a human review of the synchronous-send-failure cleanup when convenient? The updated commit also triggers a new full CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org