[GitHub] [servicecomb-java-chassis] yhs0092 commented on a change in pull request #1209: [SCB-1278] Not send x-cse* header to third party service by default

[GitBox <gi...@apache.org>]

yhs0092 commented on a change in pull request #1209: [SCB-1278] Not send x-cse* header to third party service by default
URL: https://github.com/apache/servicecomb-java-chassis/pull/1209#discussion_r288126554
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/Endpoint.java
 ##########
 @@ -61,6 +61,13 @@ public Object getAddress() {
     return address;
   }
 
+  public boolean isThirdPartyEndpoint() {
+    if (null == this.instance) {
 
 Review comment:
   I changed the way to identify whether it is a 3rd party microservice. Now it's checked by a field `thirdPartyService` in `Microservice`.
   Later if 3rd party services are supported to be registered into SC, this field can be used directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services