You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 08:35:11 UTC

[GitHub] [flink] GJL opened a new pull request #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

GJL opened a new pull request #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613
 
 
   ## What is the purpose of the change
   
   *Create currentRegion HashSet with default capacity*
   
   
   ## Brief change log
   
     - *See commit*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613#issuecomment-607705500
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5bc0702623f774a01725f56f0dc9d0ab35bec741 (Thu Apr 02 08:39:00 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613#issuecomment-607717121
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719812",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6984",
       "triggerID" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157740009",
       "triggerID" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c1022f54b126aa74e2943d573c9a6477a54bd805 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157740009) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6984) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613#issuecomment-607717121
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5bc0702623f774a01725f56f0dc9d0ab35bec741 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613#issuecomment-607717121
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719812",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5bc0702623f774a01725f56f0dc9d0ab35bec741 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719812) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL closed pull request #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
GJL closed pull request #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613#issuecomment-607717121
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719812",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6984",
       "triggerID" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157740009",
       "triggerID" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5bc0702623f774a01725f56f0dc9d0ab35bec741 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719812) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972) 
   * c1022f54b126aa74e2943d573c9a6477a54bd805 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157740009) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6984) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613#issuecomment-607717121
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719812",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5bc0702623f774a01725f56f0dc9d0ab35bec741 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157719812) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11613: [FLINK-16940][runtime] Create currentRegion HashSet with default capacity
URL: https://github.com/apache/flink/pull/11613#issuecomment-607717121
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719812",
       "triggerID" : "5bc0702623f774a01725f56f0dc9d0ab35bec741",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c1022f54b126aa74e2943d573c9a6477a54bd805",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5bc0702623f774a01725f56f0dc9d0ab35bec741 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719812) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6972) 
   * c1022f54b126aa74e2943d573c9a6477a54bd805 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services