[GitHub] [flink-kubernetes-operator] SteNicholas commented on a change in pull request #36: [FLINK-26436] InformerEventSources should only watch selected namespace

[GitBox <gi...@apache.org>]

SteNicholas commented on a change in pull request #36:
URL: https://github.com/apache/flink-kubernetes-operator/pull/36#discussion_r818573486



##########
File path: flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java
##########
@@ -52,10 +62,29 @@
 
     private final Context context = JobReconcilerTest.createContextWithReadyJobManagerDeployment();
 
+    private TestingFlinkService flinkService;
+    private FlinkDeploymentController testController;
+
+    private KubernetesMockServer mockServer;
+    private NamespacedKubernetesClient kubernetesClient;
+
+    @BeforeEach
+    public void setup() {
+        flinkService = new TestingFlinkService();
+        mockServer = new KubernetesMockServer(new MockWebServer(), new HashMap<>(), true);
+        mockServer.init();
+        kubernetesClient = mockServer.createClient();
+        testController = createTestController(kubernetesClient, flinkService);
+    }
+
+    @AfterEach
+    public void tearDown() {
+        mockServer.shutdown();

Review comment:
       Could the mock server shutdown after the kubernetes client close?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org