[GitHub] [superset] zhaoyongjie commented on pull request #19259: feat(explore): Dataset panel option tooltips

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #19259:
URL: https://github.com/apache/superset/pull/19259#issuecomment-1073742002


   > > PR LGTM.
   > > But I have a concern about the design. `Description` and `name`/`verbose_name` are used with different intents.
   > > 
   > > 1. `name`/`verbose_name` is related to query and modeling for the dataset.
   > > 2. `description` may have a lot of content for the current column/metric, this field is unrelated to query and modeling.
   > > 
   > > The description information put into the tooltip may make this popup larger than before.
   > 
   > Hey @zhaoyongjie, thanks for comments.
   > 
   > Currently this component (drag&drop field) is overloaded with tooltips and it is definitely not a good user experience. Additionally, besides the tooltip the user gets while hovering over the name, we also show 4 additional/optional tooltips that appear while hovering over an icon. This is not a good flow, as:
   > 
   >     1. icons are not that easy to understand or read as we may think,
   > 
   >     2. this section is currently overcrowded and overwhelming with all of the details.
   > 
   > 
   > Although name and description may come from the different sources, they have the same context - these are basically the details of the column or metrics, so it makes sense to put them in one tooltip. Although it may become long it will still be more readable than it is now. To make sure that long descriptions won't distract users from column name and label, I propose placing the tooltip at the bottom instead of the top by default - that way the first thing user notices is column name. <img alt="image" width="1792" src="https://user-images.githubusercontent.com/15073128/159237220-ec69050c-de86-4468-a013-823c5e612409.png">
   
   Thanks for the explanation! If this description is large, the tooltip will mask the other columns above it when the user pick another column. 
   
   https://user-images.githubusercontent.com/2016594/159245329-d444b2e7-c9ed-4075-b406-c6535a6d7e78.mov
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org