You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/17 03:17:54 UTC

[GitHub] [pulsar-client-go] sundy-li commented on issue #346: Messages should not be abstracted as interface for performance issue.

sundy-li commented on issue #346:
URL: https://github.com/apache/pulsar-client-go/issues/346#issuecomment-674633989


   Well, I think
   - You should consider the compatibility with the previous version of this client, maybe you should expose a new function.
   - Other kafka clients like `sarama` and `kafka-go` , they always make the message to be a direct struct. This is very important for high throughput usage, although the interface may beneficial to good abstraction.
   
   We can't use `ConsumerMessage`, because it's an interfaces too. 
   
   We used to abstract the message in Kafka, the lag occurs, we can't afford the performance drawback.
   ![image](https://user-images.githubusercontent.com/3325189/90354189-15d37400-e07b-11ea-87b1-96443d1ea7cc.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org