You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "paulk-asert (via GitHub)" <gi...@apache.org> on 2026/06/23 05:01:01 UTC

[PR] GROOVY-12099: Elvis-assignment on array element evaluates receiver an… [groovy]

paulk-asert opened a new pull request, #2622:
URL: https://github.com/apache/groovy/pull/2622

   …d index twice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12099: Elvis-assignment on array element evaluates receiver an… [groovy]

Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert merged PR #2622:
URL: https://github.com/apache/groovy/pull/2622


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12099: Elvis-assignment on array element evaluates receiver an… [groovy]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #2622:
URL: https://github.com/apache/groovy/pull/2622#issuecomment-4775830790

   ## 🚨 TestLens detected 1 failed test 🚨
   
   Here is what you can do:
   
   1) Inspect the test failures carefully.
   2) If you are convinced that some of the tests are flaky, you can mute them below.
   3) Finally, trigger a rerun by checking the rerun checkbox.
   
   ### Test Summary
   
   #### [Build and test / lts \(25, ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/28003393579/job/82880217947?pr=2622) > :test
   
   | Test | Runs |
   |---|---|
   | StreamClassloaderInScriptTest > testSerializationToFileWithinScript | ❌ |
   
   🏷️ Commit: 0f551951d8aa41d7a17cf06adcb4b870bbab2100
   ▶️ Tests:  41028 executed
   🟡 Checks: 5/28 completed
   
   ### Test Failures
   
   <details>
   
   <summary><strong>StreamClassloaderInScriptTest > testSerializationToFileWithinScript</strong> (:test in <a href="https://github.com/apache/groovy/actions/runs/28003393579/job/82880217947?pr=2622">Build and test / lts (25, ubuntu-latest)</a>)</summary>
   
   ```
   java.io.IOException: No space left on device
   	at java.base/java.io.FileOutputStream.writeBytes(Native Method)
   	at java.base/java.io.FileOutputStream.write(FileOutputStream.java:378)
   	at java.base/java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1765)
   	at java.base/java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1674)
   	at java.base/java.io.ObjectOutputStream.<init>(ObjectOutputStream.java:238)
   	at org.codehaus.groovy.runtime.ResourceGroovyMethods.newObjectOutputStream(ResourceGroovyMethods.java:190)
   	at org.codehaus.groovy.runtime.ResourceGroovyMethods.withObjectOutputStream(ResourceGroovyMethods.java:206)
   	at Script1.run(Script1.groovy:10)
   	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:553)
   	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:588)
   	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:562)
   	at groovy.test.GroovyShellTestCase.evaluate(GroovyShellTestCase.groovy:29)
   	at groovy.script.StreamClassloaderInScriptTest.testSerializationToFileWithinScript(StreamClassloaderInScriptTest.groovy:33)
   ```
   
   </details>
   
   ### Muted Tests
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 StreamClassloaderInScriptTest > testSerializationToFileWithinScript <!-- uniqueId=[engine:junit-vintage]/[runner:groovy.script.StreamClassloaderInScriptTest]/[test:testSerializationToFileWithinScript(groovy.script.StreamClassloaderInScriptTest)] -->
   
   Reuse successful test results:
   
   🔲 ♻️ Only rerun the tests that failed or were muted before
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12099: Elvis-assignment on array element evaluates receiver an… [groovy]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2622:
URL: https://github.com/apache/groovy/pull/2622#issuecomment-4775964479

   ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2622?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `87.50000%` with `3 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 68.4541%. Comparing base ([`40c6203`](https://app.codecov.io/gh/apache/groovy/commit/40c62030da295c38d1f851fdff15802f4cac4889?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0f55195`](https://app.codecov.io/gh/apache/groovy/commit/0f551951d8aa41d7a17cf06adcb4b870bbab2100?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2622?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...us/groovy/classgen/asm/BinaryExpressionHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2622?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FBinaryExpressionHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9CaW5hcnlFeHByZXNzaW9uSGVscGVyLmphdmE=) | 87.5000% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2622?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/groovy/pull/2622/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2622?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2622        +/-   ##
   ==================================================
   - Coverage     68.4541%   68.4541%   -0.0001%     
   - Complexity      33505      33512         +7     
   ==================================================
     Files            1518       1518                
     Lines          127107     127129        +22     
     Branches        23065      23067         +2     
   ==================================================
   + Hits            87010      87025        +15     
   - Misses          32371      32377         +6     
   - Partials         7726       7727         +1     
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2622?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...us/groovy/classgen/asm/BinaryExpressionHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2622?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FBinaryExpressionHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9CaW5hcnlFeHByZXNzaW9uSGVscGVyLmphdmE=) | `88.7346% <87.5000%> (-0.0833%)` | :arrow_down: |
   
   ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2622/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org