[DISCUSS] Move the sling hc project to felix and merge with systemready

[Christian Schneider <ch...@die-schneider.net>]

Sling health checks (hc) provide a framework to continually check the
system health of an OSGi system.
The result of the individual checks is grouped by labels and can be
retrieved using JMX and a servlet.
( https://github.com/apache?utf8=%E2%9C%93&q=sling-hc&type=&language= )

The sling community discussed to offer to move this project to felix. (
https://lists.apache.org/thread.html/d42c2064bf98d10b4f9b5d424384e2e83993e41613e643de944c7c35@%3Cdev.sling.apache.org%3E
)
By having sling hc in felix I hope this framework can reach a larger
audience than in sling.
Georg Henzler took care of changing the package names and removing
dependencies from other sling modules. He provided a zip file with a
possible initial contribution in this issue:
https://issues.apache.org/jira/browse/FELIX-5952

There is quite some overlap with felix system ready. So if we accept the
offer then we also have to look into merging the two frameworks. I think at
least for long term we should not keep both. As far as I learned the Sling
HC API can cover most of the features of the systemready framework api. As
sling hc is a lot more mature and battle proven I can imagine to move to
this basic framework and change the system ready checks to this API.

So what do you think?

Christian

-- 
-- 
Christian Schneider
http://www.liquid-reality.de

Computer Scientist
http://www.adobe.com

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[fe...@ghenzler.de]

Hi all,

since I proposed it, obviously I think it would be great to make the 
move!
(for exactly the reasons as stated in the description of FELIX-5952 [1])

>> > I think the move is a great idea but I also think a transition plan
>> > needs to be discussed on the Sling side before proceeding.

My idea was
* a clear migration path for SPI-implementers
* and (at least temporary) support for Sling HC API in the Felix Health 
Checks Executor runtime, see [2]

> FWIW, we don't typically have an issue with making people that want to
> continue maintaining contributions as committers.

This is great to hear, as mentioned [3], I would like to keep 
maintaining the module (together with others that are interested).

-Georg

[1]
https://issues.apache.org/jira/browse/FELIX-5952

[2]
https://lists.apache.org/thread.html/7699fca2bf11cb00b4f8ce2a4ffdcb1e4aa0b1d3fe6fc9705818dbb2@%3Cdev.sling.apache.org%3E
https://issues.apache.org/jira/browse/FELIX-5952?focusedCommentId=16643281&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16643281

[3]
https://issues.apache.org/jira/browse/FELIX-5952?focusedCommentId=16644915&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16644915

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Karl Pauls <ka...@gmail.com>]

On Thu, Oct 11, 2018 at 11:37 AM Christian Schneider
<ch...@die-schneider.net> wrote:
>
> The idea was to first get feedback from felix if the donation would be
> accepted at all.
> Then I propose we try to come to a final conclusion in sling dev which
> includes a migration plan.

I think it makes at least some sense to discuss it at felix at this
point because it wouldn't make much sense for Sling to vote on it
without knowing if there is interest.

> About access of sling committers to felix. This is a good question. Maybe a
> first thing we could ask on the sling side is who would be especially
> interested in maintaining the hc module at felix. Georg already volunteered
> but I think this does not have to be limited to him.
> Then of course we need to ask the felix PMC about giving access to those
> people.

FWIW, we don't typically have an issue with making people that want to
continue maintaining contributions as committers.

regards,

Karl

> Do you think that makes sense?
>
> Christian
>
> Am Do., 11. Okt. 2018 um 11:29 Uhr schrieb Bertrand Delacretaz <
> bdelacretaz@apache.org>:
>
> > Hi,
> >
> > On Thu, Oct 11, 2018 at 10:42 AM Christian Schneider
> > <ch...@die-schneider.net> wrote:
> > > ...The sling community discussed to offer to move this project to felix.
> > (
> > >
> > https://lists.apache.org/thread.html/d42c2064bf98d10b4f9b5d424384e2e83993e41613e643de944c7c35@%3Cdev.sling.apache.org%3E
> > ...
> >
> > Do you see a consensus or decision there?
> >
> > I don't - I just see a vaguely converging discussion.
> >
> > IMO on the Sling side we need a clear plan about moving and keeping
> > compatibility so that Sling users can use these new Felix Health
> > Checks.
> >
> > If we don't have that we'll probably end up with two parallel projects
> > with fractured communities - no benefits compared to now, just
> > downsides.
> >
> > Another important aspect is whether Sling committers can efficiently
> > help maintain that module if it moves to Felix - will Felix give write
> > access to Sling committers to that module? That has happened in the
> > past between related Apache projects (Cocoon and Forrest IIRC) and
> > might be a good idea here but that's a decision for the Felix PMC to
> > make. And the Sling PMC needs to take that into account before
> > considering a move, IMO.
> >
> > I think the move is a great idea but I also think a transition plan
> > needs to be discussed on the Sling side before proceeding.
> >
> > -Bertrand (Sling PMC member)
> >
>
>
> --
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Computer Scientist
> http://www.adobe.com



-- 
Karl Pauls
karlpauls@gmail.com

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Christian Schneider <ch...@die-schneider.net>]

The idea was to first get feedback from felix if the donation would be
accepted at all.
Then I propose we try to come to a final conclusion in sling dev which
includes a migration plan.

About access of sling committers to felix. This is a good question. Maybe a
first thing we could ask on the sling side is who would be especially
interested in maintaining the hc module at felix. Georg already volunteered
but I think this does not have to be limited to him.
Then of course we need to ask the felix PMC about giving access to those
people.

Do you think that makes sense?

Christian

Am Do., 11. Okt. 2018 um 11:29 Uhr schrieb Bertrand Delacretaz <
bdelacretaz@apache.org>:

> Hi,
>
> On Thu, Oct 11, 2018 at 10:42 AM Christian Schneider
> <ch...@die-schneider.net> wrote:
> > ...The sling community discussed to offer to move this project to felix.
> (
> >
> https://lists.apache.org/thread.html/d42c2064bf98d10b4f9b5d424384e2e83993e41613e643de944c7c35@%3Cdev.sling.apache.org%3E
> ...
>
> Do you see a consensus or decision there?
>
> I don't - I just see a vaguely converging discussion.
>
> IMO on the Sling side we need a clear plan about moving and keeping
> compatibility so that Sling users can use these new Felix Health
> Checks.
>
> If we don't have that we'll probably end up with two parallel projects
> with fractured communities - no benefits compared to now, just
> downsides.
>
> Another important aspect is whether Sling committers can efficiently
> help maintain that module if it moves to Felix - will Felix give write
> access to Sling committers to that module? That has happened in the
> past between related Apache projects (Cocoon and Forrest IIRC) and
> might be a good idea here but that's a decision for the Felix PMC to
> make. And the Sling PMC needs to take that into account before
> considering a move, IMO.
>
> I think the move is a great idea but I also think a transition plan
> needs to be discussed on the Sling side before proceeding.
>
> -Bertrand (Sling PMC member)
>


-- 
-- 
Christian Schneider
http://www.liquid-reality.de

Computer Scientist
http://www.adobe.com

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Bertrand Delacretaz <bd...@apache.org>]

Hi,

On Thu, Oct 11, 2018 at 10:42 AM Christian Schneider
<ch...@die-schneider.net> wrote:
> ...The sling community discussed to offer to move this project to felix. (
> https://lists.apache.org/thread.html/d42c2064bf98d10b4f9b5d424384e2e83993e41613e643de944c7c35@%3Cdev.sling.apache.org%3E ...

Do you see a consensus or decision there?

I don't - I just see a vaguely converging discussion.

IMO on the Sling side we need a clear plan about moving and keeping
compatibility so that Sling users can use these new Felix Health
Checks.

If we don't have that we'll probably end up with two parallel projects
with fractured communities - no benefits compared to now, just
downsides.

Another important aspect is whether Sling committers can efficiently
help maintain that module if it moves to Felix - will Felix give write
access to Sling committers to that module? That has happened in the
past between related Apache projects (Cocoon and Forrest IIRC) and
might be a good idea here but that's a decision for the Felix PMC to
make. And the Sling PMC needs to take that into account before
considering a move, IMO.

I think the move is a great idea but I also think a transition plan
needs to be discussed on the Sling side before proceeding.

-Bertrand (Sling PMC member)

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Karl Pauls <ka...@gmail.com>]

Hi Georg,

sorry, you are right - I dropped the ball on this one. I'll start a
new discussion summarising the situation and try to get it to a vote
soon.

Thanks for reminding me.

regards,

Karl
On Wed, Nov 21, 2018 at 11:38 AM Georg Henzler <fe...@ghenzler.de> wrote:
>
> Hi all,
>
> how should we proceed with this?
>
> -Georg
>
> > On 5. Nov 2018, at 22:29, Georg Henzler <fe...@ghenzler.de> wrote:
> >
> > Hi all,
> >
> > meanwhile the Sling community gave their ok to proceed with the move the
> > health checks module to Felix [1]. I updated the patch for an initial
> > commit at [2] to also include the web console. At the moment it is located
> > healthcheck/webconsoleplugin, but it can easily be moved to
> > webconsole-plugins if this is the preferred location (most plugins are
> > there, but there are some exceptions like ipojo/webconsole-plugin. In
> > a way I like it better to have it all bundled under one directory
> > "healthcheck".
> >
> > So as far as I can tell, I think everything would be ready for the initial
> > commit of the attached patch.
> >
> > Best Regards
> > Georg
> >
> > [1] http://apache-sling.73963.n3.nabble.com/hackathon-health-checks-tp4086283p4087711.html
> > [2] https://issues.apache.org/jira/browse/FELIX-5952?focusedCommentId=16675773&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16675773
> >
> >
> >
>


-- 
Karl Pauls
karlpauls@gmail.com

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Georg Henzler <fe...@ghenzler.de>]

Hi all, 

how should we proceed with this? 

-Georg 

> On 5. Nov 2018, at 22:29, Georg Henzler <fe...@ghenzler.de> wrote:
> 
> Hi all,
> 
> meanwhile the Sling community gave their ok to proceed with the move the
> health checks module to Felix [1]. I updated the patch for an initial
> commit at [2] to also include the web console. At the moment it is located
> healthcheck/webconsoleplugin, but it can easily be moved to
> webconsole-plugins if this is the preferred location (most plugins are
> there, but there are some exceptions like ipojo/webconsole-plugin. In
> a way I like it better to have it all bundled under one directory
> "healthcheck".
> 
> So as far as I can tell, I think everything would be ready for the initial
> commit of the attached patch.
> 
> Best Regards
> Georg
> 
> [1] http://apache-sling.73963.n3.nabble.com/hackathon-health-checks-tp4086283p4087711.html
> [2] https://issues.apache.org/jira/browse/FELIX-5952?focusedCommentId=16675773&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16675773
> 
> 
> 

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Georg Henzler <fe...@ghenzler.de>]

Hi all,

meanwhile the Sling community gave their ok to proceed with the move the
health checks module to Felix [1]. I updated the patch for an initial
commit at [2] to also include the web console. At the moment it is 
located
healthcheck/webconsoleplugin, but it can easily be moved to
webconsole-plugins if this is the preferred location (most plugins are
there, but there are some exceptions like ipojo/webconsole-plugin. In
a way I like it better to have it all bundled under one directory
"healthcheck".

So as far as I can tell, I think everything would be ready for the 
initial
commit of the attached patch.

Best Regards
Georg

[1] 
http://apache-sling.73963.n3.nabble.com/hackathon-health-checks-tp4086283p4087711.html
[2] 
https://issues.apache.org/jira/browse/FELIX-5952?focusedCommentId=16675773&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16675773


On 2018-10-12 11:39, Andrei Dulvac wrote:
> +1
> 
> I think it's best we have the HCs in Felix and work on a merge of HCs 
> and
> systemready.
> 
> - Andrei
> 
> On Fri, Oct 12, 2018 at 11:34 AM Carsten Ziegeler 
> <cz...@apache.org>
> wrote:
> 
>> As there is a lot of overlap and an indication from all sides to work
>> together on a single solution, +1 for working on this solution in the
>> Apache Felix project.
>> 
>> Regards
>> Carsten
>> 
>> Am 11.10.2018 um 09:41 schrieb Christian Schneider:
>> > Sling health checks (hc) provide a framework to continually check the
>> > system health of an OSGi system.
>> > The result of the individual checks is grouped by labels and can be
>> > retrieved using JMX and a servlet.
>> > ( https://github.com/apache?utf8=%E2%9C%93&q=sling-hc&type=&language= )
>> >
>> > The sling community discussed to offer to move this project to felix. (
>> >
>> https://lists.apache.org/thread.html/d42c2064bf98d10b4f9b5d424384e2e83993e41613e643de944c7c35@%3Cdev.sling.apache.org%3E
>> > )
>> > By having sling hc in felix I hope this framework can reach a larger
>> > audience than in sling.
>> > Georg Henzler took care of changing the package names and removing
>> > dependencies from other sling modules. He provided a zip file with a
>> > possible initial contribution in this issue:
>> > https://issues.apache.org/jira/browse/FELIX-5952
>> >
>> > There is quite some overlap with felix system ready. So if we accept the
>> > offer then we also have to look into merging the two frameworks. I think
>> at
>> > least for long term we should not keep both. As far as I learned the
>> Sling
>> > HC API can cover most of the features of the systemready framework api.
>> As
>> > sling hc is a lot more mature and battle proven I can imagine to move to
>> > this basic framework and change the system ready checks to this API.
>> >
>> > So what do you think?
>> >
>> > Christian
>> >
>> 
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziegeler@apache.org
>> 

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Andrei Dulvac <du...@apache.org>]

+1

I think it's best we have the HCs in Felix and work on a merge of HCs and
systemready.

- Andrei

On Fri, Oct 12, 2018 at 11:34 AM Carsten Ziegeler <cz...@apache.org>
wrote:

> As there is a lot of overlap and an indication from all sides to work
> together on a single solution, +1 for working on this solution in the
> Apache Felix project.
>
> Regards
> Carsten
>
> Am 11.10.2018 um 09:41 schrieb Christian Schneider:
> > Sling health checks (hc) provide a framework to continually check the
> > system health of an OSGi system.
> > The result of the individual checks is grouped by labels and can be
> > retrieved using JMX and a servlet.
> > ( https://github.com/apache?utf8=%E2%9C%93&q=sling-hc&type=&language= )
> >
> > The sling community discussed to offer to move this project to felix. (
> >
> https://lists.apache.org/thread.html/d42c2064bf98d10b4f9b5d424384e2e83993e41613e643de944c7c35@%3Cdev.sling.apache.org%3E
> > )
> > By having sling hc in felix I hope this framework can reach a larger
> > audience than in sling.
> > Georg Henzler took care of changing the package names and removing
> > dependencies from other sling modules. He provided a zip file with a
> > possible initial contribution in this issue:
> > https://issues.apache.org/jira/browse/FELIX-5952
> >
> > There is quite some overlap with felix system ready. So if we accept the
> > offer then we also have to look into merging the two frameworks. I think
> at
> > least for long term we should not keep both. As far as I learned the
> Sling
> > HC API can cover most of the features of the systemready framework api.
> As
> > sling hc is a lot more mature and battle proven I can imagine to move to
> > this basic framework and change the system ready checks to this API.
> >
> > So what do you think?
> >
> > Christian
> >
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
>

Re: [DISCUSS] Move the sling hc project to felix and merge with systemready

[Carsten Ziegeler <cz...@apache.org>]

As there is a lot of overlap and an indication from all sides to work 
together on a single solution, +1 for working on this solution in the 
Apache Felix project.

Regards
Carsten

Am 11.10.2018 um 09:41 schrieb Christian Schneider:
> Sling health checks (hc) provide a framework to continually check the
> system health of an OSGi system.
> The result of the individual checks is grouped by labels and can be
> retrieved using JMX and a servlet.
> ( https://github.com/apache?utf8=%E2%9C%93&q=sling-hc&type=&language= )
> 
> The sling community discussed to offer to move this project to felix. (
> https://lists.apache.org/thread.html/d42c2064bf98d10b4f9b5d424384e2e83993e41613e643de944c7c35@%3Cdev.sling.apache.org%3E
> )
> By having sling hc in felix I hope this framework can reach a larger
> audience than in sling.
> Georg Henzler took care of changing the package names and removing
> dependencies from other sling modules. He provided a zip file with a
> possible initial contribution in this issue:
> https://issues.apache.org/jira/browse/FELIX-5952
> 
> There is quite some overlap with felix system ready. So if we accept the
> offer then we also have to look into merging the two frameworks. I think at
> least for long term we should not keep both. As far as I learned the Sling
> HC API can cover most of the features of the systemready framework api. As
> sling hc is a lot more mature and battle proven I can imagine to move to
> this basic framework and change the system ready checks to this API.
> 
> So what do you think?
> 
> Christian
> 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org