You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/22 13:32:59 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #444: Fixing ldap form
davidjumani opened a new pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444
Requires https://github.com/apache/cloudstack/pull/4164 to list domain-specific LDAP configs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-649429870
Discussed with @DaanHoogland Good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648559830
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648123591
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/444 (JID-2100)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648117318
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648166329
@rhtyd Right now, listLdapUsers does not support search or pagination
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-649438825
looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648559603
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648116906
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648669046
@davidjumani add information pop-over like other forms, add doc-link to the custom form (somewhere put a <a-icon for question and link to this.$config.docBase + ....)
Also test/check against old UI.
Primate API call runs:
```
domainid: 78ec0573-03fb-4c02-872a-b0f3a86471dc
roleid: 16919363-5fe0-11ea-9a56-1e006800018c
timezone: ACT
networkdomain: net-domain
group: group
username: ldapman
command: importLdapUsers
response: json
```
Legacy UI runs:
```
command: importLdapUsers
domainid: e4874e10-5fdf-11ea-9a56-1e006800018c
account: acount-name
roleid: 16919363-5fe0-11ea-9a56-1e006800018c
timezone: Pacific/Johnston
networkdomain: net-domain
group: ldap-group
response: json
```
Mismatch account not passed, instead username? Also, the label 'Group' should say 'LDAP Group'. Check the form against old UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648897686
@rhtyd In the legacy UI, although the default filter is 'No Filter', the initial listLdapUsrers call uses 'Any Domain' as its filter. In this case, using 'No Filter' for the initial listLdapUsrers call. Should I change it to match the legacy UI ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648567018
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/444 (JID-2108)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648124305
@rhtyd good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648124388
@rhtyd good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #444: Fixing ldap form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #444:
URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-649229127
@davidjumani can you discuss with @DaanHoogland ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org