You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/12/01 18:07:00 UTC

[kudu-CR] Impala integration doc: clarify partitioning recommendations

Hello Anonymous Coward #354, Mike Percy, Jean-Daniel Cryans,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8714

to review the following change.


Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................

Impala integration doc: clarify partitioning recommendations

Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
---
M docs/kudu_impala_integration.adoc
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/8714/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8714
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Anonymous Coward #354
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Impala integration doc: clarify partitioning recommendations

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Anonymous Coward #354, Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8714

to look at the new patch set (#2).

Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................

Impala integration doc: clarify partitioning recommendations

Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
---
M docs/kudu_impala_integration.adoc
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/8714/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8714
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Anonymous Coward #354
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Impala integration doc: clarify partitioning recommendations

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8714 )

Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8714
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Anonymous Coward #354
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 01 Dec 2017 18:21:22 +0000
Gerrit-HasComments: No

[kudu-CR] Impala integration doc: clarify partitioning recommendations

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8714 )

Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8714
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Anonymous Coward #354
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 01 Dec 2017 18:09:59 +0000
Gerrit-HasComments: No

[kudu-CR] Impala integration doc: clarify partitioning recommendations

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8714 )

Change subject: Impala integration doc: clarify partitioning recommendations
......................................................................

Impala integration doc: clarify partitioning recommendations

Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Reviewed-on: http://gerrit.cloudera.org:8080/8714
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Dan Burkert <da...@apache.org>
---
M docs/kudu_impala_integration.adoc
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Will Berkeley: Looks good to me, approved
  Dan Burkert: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I67505f7a6aaa3c065877e742aaa7b77cf8394b55
Gerrit-Change-Number: 8714
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Anonymous Coward #354
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>