You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/18 12:03:25 UTC
[GitHub] [cordova-plugin-inappbrowser] coffeemicha opened a new pull request #841: (ios) Add "clearswregistrations" option to remove Service Worker registrations on iOS
coffeemicha opened a new pull request #841:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/841
### Platforms affected
iOS
### Motivation and Context
We have had trouble with Service Worker registrations not being cleaned up after opening a Service Worker-enabled website within IAB.
This PR adds a new IAB attribute "clearswregistrations" that will clear up all Service Worker registrations from the IAB website data before startup
### Description
When setting the "clearswregistrations=yes" parameter, all registrations will be removed from the [WKWebsiteDataStore defaultDataStore]
### Testing
Started IAB with the parameter set to "YES", "NO" and unset.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [X] I added automated test coverage as appropriate for this change
- [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [X] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] coffeemicha closed pull request #841: (ios) Add "clearswregistrations" option to remove Service Worker registrations on iOS
Posted by GitBox <gi...@apache.org>.
coffeemicha closed pull request #841:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org