You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/07/24 11:03:17 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1755: [CELEBORN-656][FOLLOWUP] Remove unnecessary call stageEnded when revive return STAGE_ENDE
AngersZhuuuu opened a new pull request, #1755:
URL: https://github.com/apache/incubator-celeborn/pull/1755
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1755: [CELEBORN-656][FOLLOWUP] Fix wrong message call when revive return STAGE_END
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1755: [CELEBORN-656][FOLLOWUP] Fix wrong message call when revive return STAGE_END
URL: https://github.com/apache/incubator-celeborn/pull/1755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1755: [CELEBORN-656][FOLLOWUP] Remove unnecessary call stageEnded when revive return STAGE_ENDE
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1755:
URL: https://github.com/apache/incubator-celeborn/pull/1755#discussion_r1272151974
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -729,7 +729,6 @@ Map<Integer, Integer> reviveBatch(
pushExcludedWorkers.remove(loc.getPeer().hostAndPushPort());
}
} else if (StatusCode.STAGE_ENDED.getValue() == statusCode) {
- stageEnded(shuffleId);
Review Comment:
Better to call `stageEndShuffleSet.put(shuffleId)` ? I think that's the original purpose...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1755: [CELEBORN-656][FOLLOWUP] Remove unnecessary call stageEnded when revive return STAGE_ENDE
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1755:
URL: https://github.com/apache/incubator-celeborn/pull/1755#discussion_r1272151974
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -729,7 +729,6 @@ Map<Integer, Integer> reviveBatch(
pushExcludedWorkers.remove(loc.getPeer().hostAndPushPort());
}
} else if (StatusCode.STAGE_ENDED.getValue() == statusCode) {
- stageEnded(shuffleId);
Review Comment:
Better to call `stageEndShuffleSet.put(shuffleId)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1755: [CELEBORN-656][FOLLOWUP] Remove unnecessary call stageEnded when revive return STAGE_ENDE
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1755:
URL: https://github.com/apache/incubator-celeborn/pull/1755#discussion_r1272181536
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -729,7 +729,6 @@ Map<Integer, Integer> reviveBatch(
pushExcludedWorkers.remove(loc.getPeer().hostAndPushPort());
}
} else if (StatusCode.STAGE_ENDED.getValue() == statusCode) {
- stageEnded(shuffleId);
Review Comment:
Yea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1755: [CELEBORN-656][FOLLOWUP] Remove unnecessary call stageEnded when revive return STAGE_ENDE
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1755:
URL: https://github.com/apache/incubator-celeborn/pull/1755#issuecomment-1647709460
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1755?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1755](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1755?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1676cd0) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/8e849645eb3de0f6b889a14b45b618ad7a1de33c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8e84964) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1755 +/- ##
==========================================
+ Coverage 46.70% 46.72% +0.02%
==========================================
Files 161 161
Lines 10022 10021 -1
Branches 925 925
==========================================
+ Hits 4680 4681 +1
+ Misses 5022 5021 -1
+ Partials 320 319 -1
```
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1755/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org