You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/19 22:03:38 UTC

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

apeforest commented on a change in pull request #15593: Large Index Support for Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r305538372
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -548,15 +549,14 @@ MXNET_DLL int MXNDArrayCreate(const mx_uint *shape,
  * \param out the returning handle
  * \return 0 when success, -1 when failure happens
  */
-MXNET_DLL int MXNDArrayCreateEx(const mx_uint *shape,
+MXNET_DLL int MXNDArrayCreateEx(const mx_int64 *shape,
 
 Review comment:
   Two reasons:
   (1) According to Google C++ style guide: "Do not use an unsigned type merely to assert that a variable is non-negative." https://google.github.io/styleguide/cppguide.html#Integer_Types
   
   (2) We intentionally changed to int because we may reserve the index -1 for supporting empty tensor.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services